Improve performance of the "fix permissions" step in ncp-update-nc

[powerflo]

The "fix permissions" step is really slow when the nextcloud folder contains a lot of data. In a docker setup the data directory is in nextcloud/data so the folder can be really big. Even on my small test setup the "fix permissions" step took more than 20 minutes. Using "chmod -R ..." reduces the time to around 20 seconds.

Signed-off-by: Florian Wallner asdf@walura.eu

[TobiGr]

This should really be merged, the fix permissions step took more than 30 minutes on my setup.

[schoetju]

I would like to join in saying that improving the performance of “fix permissions” would be really helpful. On my instance the step also takes about 15 minutes (and I get nervous when it doesn't seem to continue during the update).
As I understand it, the changes suggested by powerflo are functionally identical with significantly better performance.
@theCalcaholic Is there any concern that the change is patchy or buggy? Can we / community somehow support?

[korhadris]

As a fix that will avoid the recursive chmod as well as fixing #2005, I'd recommend that when the copy is performed, that it is done as the www-data user directly. There's probably multiple places where the sudo -u www-data should be added to fix #2005.