fix: remove favorite marker from map immediately after deletion - #1636
Open
sim6 wants to merge 1 commit into
Open
fix: remove favorite marker from map immediately after deletion#1636sim6 wants to merge 1 commit into
sim6 wants to merge 1 commit into
Conversation
Replace `this.$delete()` with native `delete` in all favorite deletion paths (single delete, bulk delete, category unlink). `this.$delete()` is a Vue 2 compatibility shim that may not reliably trigger Vue 3's Proxy-based reactivity system when removing keys from a reactive object. This caused the FavoritesLayer deep watcher on displayedFavorites to not fire, leaving stale markers on the map until a full reload. In Vue 3, the native `delete` operator is intercepted by the Proxy's deleteProperty trap, which properly triggers reactivity. Affected methods: - onFavoriteDelete (single favorite via sidebar/popup) - onFavoritesDelete (bulk delete via cluster right-click) - onDeleteFavoriteCategoryFromMap (unlink shared category) Signed-off-by: Simó Albert i Beltran <sim6@probeta.net>
Contributor
Author
|
@CarlSchwan Could you review it? |
CarlSchwan
approved these changes
Jul 30, 2026
CarlSchwan
enabled auto-merge
July 30, 2026 14:17
Member
|
Thanks for the fix and sorry for the delay, so much stuff to do lately on my $work time :( |
Contributor
Author
|
The test failures are infrastructure-related, not code-related. |
Contributor
Author
|
@CarlSchwan No rush at all, and thanks for your work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
this.$delete()with nativedeletein all favorite deletion paths (single delete, bulk delete, category unlink).this.$delete()is a Vue 2 compatibility shim that may not reliably trigger Vue 3's Proxy-based reactivity system when removing keys from a reactive object. This caused the FavoritesLayer deep watcher on displayedFavorites to not fire, leaving stale markers on the map until a full reload.In Vue 3, the native
deleteoperator is intercepted by the Proxy's deleteProperty trap, which properly triggers reactivity.Affected methods: