Fix category selection not applying in favorite edit form - #1635
Open
sim6 wants to merge 2 commits into
Open
Conversation
Remove the inputLabel prop from NcSelect in FavoriteEditionForm.vue that was rendering the string 'label' as visible text above the categories dropdown when editing a favourite. Signed-off-by: Simó Albert i Beltran <sim6@probeta.net>
The category dropdown used the @input event to detect selections, but NcSelect (from @nextcloud/vue v9) only emits update:modelValue. The handler never fired, leaving the internal category state stale while the visual v-model appeared correct. Replace @input with @update:modelValue so the onCategorySelected handler runs when a category is picked from the dropdown. Signed-off-by: Simó Albert i Beltran <sim6@probeta.net>
Contributor
Author
|
@CarlSchwan Could you review it? |
CarlSchwan
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes text "label" on top of favorite edit form category dropdown.