refactor: add null guards in db mappers and fix JsonResponse return type for Psalm 6#12874
Open
ChristophWurst wants to merge 1 commit intomainfrom
Open
refactor: add null guards in db mappers and fix JsonResponse return type for Psalm 6#12874ChristophWurst wants to merge 1 commit intomainfrom
ChristophWurst wants to merge 1 commit intomainfrom
Conversation
…ype for Psalm 6 - LocalMessageMapper: guard getLocalMessageId() before using as array key in findAll, findDue, findDueDrafts; use ?? [] for getRecipients() - MessageMapper: extract getMessageId() to variable with null guard before using as array key in updateTags and findRelatedData - JsonResponse: align @return static → @return self on errorFromThrowable to match actual return type hint AI-assisted: Claude Code (claude-sonnet-4-6) Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocalMessageMapper: add null guard forgetLocalMessageId()before using as array key ingetAllForUser,findDue,findDueDrafts; use?? []forgetRecipients()inupdateWithRecipientsMessageMapper: extractgetMessageId()to a local variable with null guard before using as array key inupdateTagsandfindRelatedDataJsonResponse: align@return static→@return selfonerrorFromThrowableto match the actual PHP return type hintThese are Psalm 6
PossiblyNullArrayOffsetandMoreSpecificReturnTypeerrors that remain after the Psalm v6 upgrade in #11224.Test plan
composer test:unit)composer psalm)Part of #11224