Merged
Conversation
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
DerDreschner
approved these changes
Jan 9, 2026
Contributor
|
Is there a separate ticket to check and update our dependencies against PHP 8.5? I'm asking as there are a bunch of deprecation warnings when using >= 8.5. https://github.com/nextcloud/mail/actions/runs/20856973971/job/59926192916?pr=12227#step:11:30 (A lot of them should appear with PHP 8.4 as well according to the deprecation warning, but they don't in our PHP 8.4 pipeline for some reason 🤔 ) |
Member
Author
|
I suggest we fix them in the coming weeks as we see them pop up on CI or with local testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have run tests with PHP8.5 for a long time. Now that server supports 8.5 we can allow it too.
The test workflow is already adjusted for 8.6 once we add it to the matrix.