Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new “Focused Auto Upload” flow around the existing auto-upload feature, so users can open a dedicated progress screen, keep the app awake, and darken the display during uploads. It also updates the Settings entry to show a live upload state/count and introduces the supporting localized copy for the new UI.
Changes:
- Added new focused auto-upload UI components: intro sheet, full-screen progress view, screen dimmer, and animated cloud icon.
- Updated Auto Upload and Settings screens to surface the new focused mode and show a live remaining-items counter.
- Added database counting logic and new English localization strings/plurals to support the new progress messaging.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
Nextcloud.xcodeproj/project.pbxproj |
Adds the new focused auto-upload Swift files to the app target. |
iOSClient/Supporting Files/en.lproj/Localizable.stringsdict |
Adds pluralized strings for remaining-item and progress counters. |
iOSClient/Supporting Files/en.lproj/Localizable.strings |
Updates transfer wording and adds focused auto-upload copy. |
iOSClient/Settings/Settings/NCSettingsView.swift |
Replaces the settings icon/label with animated auto-upload status UI and starts count polling. |
iOSClient/Settings/Settings/NCSettingsModel.swift |
Adds auto-upload state/count tracking and polling logic for Settings. |
iOSClient/Settings/AutoUpload/NCFocusedAutoUploadScreenDimmer.swift |
New helper to keep the screen awake, dim brightness, and restore state. |
iOSClient/Settings/AutoUpload/NCFocusedAutoUploadProgressView.swift |
New full-screen focused-mode progress UI with countdown and queue polling. |
iOSClient/Settings/AutoUpload/NCFocusedAutoUploadIntroView.swift |
New intro sheet explaining focused auto-upload before entering the progress screen. |
iOSClient/Settings/AutoUpload/NCFocusedAutoUploadCloudAnimation.swift |
New reusable animated/static cloud indicator for focused auto-upload. |
iOSClient/Settings/AutoUpload/NCAutoUploadView.swift |
Adds the focused auto-upload entry point and modal flow inside auto-upload settings. |
iOSClient/Data/NCManageDatabase+AutoUpload.swift |
Adds async counting of remaining auto-upload metadata, excluding recently completed transfers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if let originalIdleTimerDisabled { | ||
| UIApplication.shared.isIdleTimerDisabled = originalIdleTimerDisabled |
| } | ||
|
|
||
| private var uploadCountMessage: String { | ||
| return String.localizedStringWithFormat(NSLocalizedString("_focused_auto_upload_photos_to_back_up_", comment: ""), autoUploadCount) |
| <key>NSStringFormatValueTypeKey</key> | ||
| <string>d</string> | ||
| <key>one</key> | ||
| <string>You have %d photo to back up</string> |
| return results | ||
| .filter("NOT (ocIdTransfer IN %@)", Array(excludedIds)) | ||
| .count | ||
| } ?? 0 |
There was a problem hiding this comment.
We filter out auto upload success files. Is that ok? @marinofaggiana
1569 - 1649 ? mmm maybe tre webdav directory creation ? image: total black it has never been used... the touch on button works only on title and the ">" is not correct, it should be a normal button not a push
To do:
I would leave it anyway, is it in conflict or what? |
To do: