feat: show new OpenProject work package display ID#1071
Draft
saw-jan wants to merge 4 commits into
Draft
Conversation
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
force-pushed
the
feat/show-new-op-wp-id
branch
from
96de1c2 to
7649474
Compare
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
force-pushed
the
feat/show-new-op-wp-id
branch
from
7649474 to
2b7dfb0
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds support for OpenProject’s semantic “display ID” for work packages while keeping numeric IDs prefixed with #, and updates tests/config accordingly.
Changes:
- Introduces
displayIdinto the normalized work package model and renders it inWorkPackage.vuewith numeric-vs-semantic formatting. - Expands Jest unit test coverage/snapshots for both “old” numeric IDs and new semantic IDs.
- Updates Jest config ignore patterns and changelog entry.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/jest/components/tab/snapshots/WorkPackage.spec.js.snap | Updates snapshots for old vs new display ID rendering. |
| tests/jest/components/tab/snapshots/SearchInput.spec.js.snap | Adds displayId to the search input snapshot payload. |
| tests/jest/components/tab/WorkPackage.spec.js | Adds separate test cases for numeric vs semantic displayId rendering. |
| src/utils/workpackageHelper.js | Includes displayId in the normalized work package object. |
| src/components/tab/WorkPackage.vue | Displays formatted displayId (numeric gets # prefix). |
| jest.config.js | Adds ignore patterns for tests/modules under server/ (and dev/ for modules). |
| CHANGELOG.md | Documents the new feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
PHP Code CoverageCoverage after merging feat/show-new-op-wp-id into release/2.11 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
Author
|
Create |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Show new OpenProject work package display id.
As per the requirement,
#<id>. E.g.:#123<id>: #.g.:ABC-123For Testing
Administration -> Work packages -> IdentifiersRelated Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile