Fix: throw UnknownActivityException on Notifier#372
Merged
Conversation
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
lukasdotcom
force-pushed
the
fix/UnknownActivityException
branch
from
50e207f to
f46b19c
Compare
kyteinsky
approved these changes
May 18, 2026
|
|
||
| use InvalidArgumentException; | ||
| use OCA\OpenAi\AppInfo\Application; | ||
| use OCP\Activity\Exceptions\UnknownActivityException; |
Member
There was a problem hiding this comment.
In the notifier you need to throw OCP\Notification\UnknownNotificationException
the UnknownActivityException exception is only for activity parsing 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.