fix: email shares need to convert recipient for userid#1572
Open
susnux wants to merge 1 commit into
Open
Conversation
`shareWith` of an email share is the email address. But the email address is NOT always the userId. So for that case we need to convert the email to the userId. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
commented
May 19, 2026
| } | ||
|
|
||
| $isGuest = $this->guestManager->isGuest($shareWith); | ||
| $isGuest = $this->guestManager->isGuest($guestId); |
Contributor
Author
There was a problem hiding this comment.
while isGuest also does this check we need the conversion anyways later for the sendInvite
|
If not mistaken, these are default values?
So what are steps to reach the new code? |
Contributor
Author
Well its the same as old code ;) But would it not make sense to convert email shares to user shares then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shareWithof an email share is the email address. But the email address is NOT always the userId.So for that case we need to convert the email to the userId.