fix: do not add result permissions to see own submissions #3128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/backport to stable5.2 |
Collaborator
|
Just checked it, seems to fully fix the issue :) Thanks! |
Chartman123
approved these changes
Jan 22, 2026
Collaborator
Chartman123
left a comment
Chartman123
left a comment
There was a problem hiding this comment.
Looks good, just the failing tests :)
When a user has submitted a form they should not have result permissions, but instead we should only show their own submissions. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Collaborator
Author
Randomly worked before as the parameters were passed positional but in the meantime we added new parameters 🙈 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
/backport to stable5.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has submitted a form they should not have result permissions, but instead we should only show their own submissions.