Skip to content

Refactor code for compliance with new eslint version#2957

Merged
Chartman123 merged 1 commit into
mainfrom
refactor/vue3
Oct 15, 2025
Merged

Refactor code for compliance with new eslint version#2957
Chartman123 merged 1 commit into
mainfrom
refactor/vue3

Conversation

@Chartman123
Copy link
Copy Markdown
Collaborator

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

Comment thread src/Forms.vue
Comment thread eslint.config.js Outdated
Comment thread eslint.config.js Outdated
@Chartman123 Chartman123 force-pushed the refactor/vue3 branch 4 times, most recently from 53c999f to e2de6ab Compare October 10, 2025 12:45
@susnux
Copy link
Copy Markdown
Collaborator

susnux commented Oct 10, 2025

I think we now have two options:

  • keep prettier and add it to the eslint config
  • remove prettier and solely rely on the eslint formatting

@Chartman123
Copy link
Copy Markdown
Collaborator Author

I think we now have two options:

* keep prettier and add it to the eslint config

* remove prettier and solely rely on the eslint formatting

I'd say let's keep prettier? Or does this have any bigger downsides?

@Chartman123 Chartman123 force-pushed the refactor/vue3 branch 5 times, most recently from 84e7845 to 9eed7f7 Compare October 10, 2025 22:16
@Chartman123 Chartman123 self-assigned this Oct 10, 2025
@Chartman123 Chartman123 added dependencies Pull requests that update a dependency file javascript Javascript related ticket 2. developing Work in progress technical debt Technical issue labels Oct 10, 2025
@Chartman123 Chartman123 added this to the 5.3 milestone Oct 10, 2025
Comment thread package.json Outdated
Comment thread src/FormsSettings.vue Outdated
@Chartman123 Chartman123 force-pushed the refactor/vue3 branch 5 times, most recently from c60a115 to 7e2be32 Compare October 14, 2025 23:20
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 14, 2025
@Chartman123 Chartman123 marked this pull request as ready for review October 14, 2025 23:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.18%. Comparing base (db02854) to head (eb0e27d).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2957   +/-   ##
=========================================
  Coverage     44.18%   44.18%           
  Complexity     1031     1031           
=========================================
  Files            80       80           
  Lines          3705     3705           
=========================================
  Hits           1637     1637           
  Misses         2068     2068           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/components/Questions/QuestionDropdown.vue
Comment thread eslint.config.js Outdated
Copy link
Copy Markdown
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing prettier ci?
In case we do not enforce this on CI, we could also just completely remove prettier and just use eslint for formatting.

@Chartman123
Copy link
Copy Markdown
Collaborator Author

why removing prettier ci? In case we do not enforce this on CI, we could also just completely remove prettier and just use eslint for formatting.

Because it's already monitored in ESLint... If you have code, that doesn't comply to prettier rules, eslint will fail. So we don't need it twice

@susnux
Copy link
Copy Markdown
Collaborator

susnux commented Oct 15, 2025

Because it's already monitored in ESLint... If you have code, that doesn't comply to prettier rules, eslint will fail. So we don't need it twice

Ah ok makes sense :)

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Signed-off-by: GitHub <noreply@github.com>
@Chartman123 Chartman123 merged commit 7c9df84 into main Oct 15, 2025
53 checks passed
@Chartman123 Chartman123 deleted the refactor/vue3 branch October 15, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies Pull requests that update a dependency file javascript Javascript related ticket technical debt Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants