Refactor code for compliance with new eslint version#2957
Conversation
53c999f to
e2de6ab
Compare
|
I think we now have two options:
|
I'd say let's keep prettier? Or does this have any bigger downsides? |
84e7845 to
9eed7f7
Compare
9eed7f7 to
5278581
Compare
c60a115 to
7e2be32
Compare
7e2be32 to
10b69d2
Compare
10b69d2 to
d4c3ca2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2957 +/- ##
=========================================
Coverage 44.18% 44.18%
Complexity 1031 1031
=========================================
Files 80 80
Lines 3705 3705
=========================================
Hits 1637 1637
Misses 2068 2068 🚀 New features to boost your workflow:
|
susnux
left a comment
There was a problem hiding this comment.
why removing prettier ci?
In case we do not enforce this on CI, we could also just completely remove prettier and just use eslint for formatting.
Because it's already monitored in ESLint... If you have code, that doesn't comply to prettier rules, eslint will fail. So we don't need it twice |
Ah ok makes sense :) |
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: GitHub <noreply@github.com>
d24983e to
eb0e27d
Compare
Signed-off-by: Christian Hartmann chris-hartmann@gmx.de