fix: #2767 Search field loses focus after search#2870
Conversation
17c3903 to
e0b9772
Compare
e0b9772 to
57a01f1
Compare
|
Mates, I don't know how to fix eslint, please help 🙏 |
Chartman123
left a comment
There was a problem hiding this comment.
The lint error comes from a wrong filename in the import :)
susnux
left a comment
There was a problem hiding this comment.
I do not see how this fixes the issue - it just delays it
bf4646e to
2025561
Compare
|
@susnux mate, I properly tested PR before submitting. To prove that fix works I've added a video to the PR description. There is only one case when we're loosing focus: by click of "clear" button. But I'm pretty sure that its normal behavior of ui library. I'm using latest version of the Firefox on Ubuntu. But it was tested also on Chrome. |
a264363 to
7b309a4
Compare
|
@Chartman123 @susnux guys, it not works as expected without this new The main difference of this computed property comparing to the old implementation is that now we're delaying write to Here an video which shown that we're still loosing focus when nextcloud-forms-2025-09-07_15.58.56.mp4 |
|
@Koc your latest commit is reverting changes to the icons. Please keep the changes to use the outlined icons :) |
1f6cc5b to
6c1cdda
Compare
|
@Chartman123 good catch! It happened during conflict resolution. Now should be better, please check one more time |
|
@Koc I think I found a solution for keeping our default "debounce" function and eliminating the focus loss. We have to switch the condition for disabling the PillMenu, the search I changed With that change we don't have to rely on the debouncing but fix the root cause of the focus loss by removing unneccessary re-renders. I added a commit to your PR. Please review and test it 🙂 |
|
@Chartman123 It works! Thank you |
|
@Koc great :) You can just squash the two commits into one and then we can merge the fix 👍🏻 |
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
de03b30 to
a96912a
Compare

This PR closes #2767. Better to review with ignored whitespaces and in split view
nextcloud-forms-2025-08-19_21.39.03.mp4