fix: show toast on errors with empty response

[hamza221]

Repro:

Status code	Response

On submit, Toast doesn't show, leaving the user unsure whether the submission went through

[Chartman123]

Here's more information about the error itself that leads to the missing message in the frontend:

Error message in the logfile:

{"reqId":"47nAIhY7pkRZiS7G2tFZ","level":3,"time":"2025-05-21T12:39:17+00:00","remoteAddr":"192.168.21.5","user":"user1","app":"PHP","method":"POST","url":"/ocs/v2.php/apps/forms/api/v3/forms/1/submissions","message":"Class OCA\\Notifications\\FakeUser contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\\IUser::canChangeEmail) at /var/www/html/apps/notifications/lib/FakeUser.php#13","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Safari/537.36","version":"32.0.0.0","data":{"app":"PHP"}}

The OCA\Notifications\ part of the log message leads to the ActivityManager that is called in newSubmission and updateSubmission via notifyNewSubmission in FormsService. So we should probably add some error handling here

forms/lib/Service/FormsService.php

Lines 586 to 599 in 7e7c74f

	public function notifyNewSubmission(Form $form, Submission $submission): void {
	$shares = $this->getShares($form->getId());
	$this->activityManager->publishNewSubmission($form, $submission->getUserId());
	foreach ($shares as $share) {
	if (!in_array(Constants::PERMISSION_RESULTS, $share['permissions'])) {
	continue;
	}
	$this->activityManager->publishNewSharedSubmission($form, $share['shareType'], $share['shareWith'], $submission->getUserId());
	}
	$this->eventDispatcher->dispatchTyped(new FormSubmittedEvent($form, $submission));
	}

or here

forms/lib/Activity/ActivityManager.php

Lines 111 to 166 in 7e7c74f

	public function publishNewSubmission(Form $form, string $submitterID): void {
	$event = $this->manager->generateEvent();
	$event->setApp($this->appName)
	->setType(ActivityConstants::TYPE_NEWSUBMISSION)
	->setAffectedUser($form->getOwnerId())
	->setAuthor($submitterID)
	->setSubject(ActivityConstants::SUBJECT_NEWSUBMISSION, [
	'userId' => $submitterID,
	'formTitle' => $form->getTitle(),
	'formHash' => $form->getHash()
	])
	->setObject('form', $form->getId());
	$this->manager->publish($event);
	}
	/**
	* Publish a new-Submission Activity for shared forms
	*
	* @param Form $form The affected Form
	* @param string $submitterID ID of the User who submitted the form. Can also be our 'anon-user-'-ID
	*/
	public function publishNewSharedSubmission(Form $form, int $shareType, string $shareWith, string $submitterID): void {
	$users = [];
	switch ($shareType) {
	case IShare::TYPE_USER:
	$users[] = $shareWith;
	break;
	case IShare::TYPE_GROUP:
	$group = $this->groupManager->get($shareWith);
	if ($group !== null) {
	$users = array_map(fn (IUser $user) => $user->getUID(), $group->getUsers());
	}
	break;
	case IShare::TYPE_CIRCLE:
	$users = $this->circlesService->getCircleUsers($shareWith);
	break;
	}
	foreach ($users as $userId) {
	$event = $this->manager->generateEvent();
	$event->setApp($this->appName)
	->setType(ActivityConstants::TYPE_NEWSHAREDSUBMISSION)
	->setAffectedUser($userId)
	->setAuthor($submitterID)
	->setSubject(ActivityConstants::SUBJECT_NEWSUBMISSION, [
	'userId' => $submitterID,
	'formTitle' => $form->getTitle(),
	'formHash' => $form->getHash()
	])
	->setObject('form', $form->getId());
	$this->manager->publish($event);
	}
	}
	}

[hamza221]

Fixed here : https://github.com/nextcloud/notifications/pull/2362/files

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 18 lines in your changes missing coverage. Please review.

Project coverage is 45.39%. Comparing base (699f8f7) to head (51e3427).
Report is 50 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2750      +/-   ##
============================================
- Coverage     45.58%   45.39%   -0.20%     
- Complexity      984      987       +3     
============================================
  Files            79       79              
  Lines          3565     3580      +15     
============================================
  Hits           1625     1625              
- Misses         1940     1955      +15     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.