Skip to content

fix(validation): Update validationType handling#2685

Merged
Chartman123 merged 1 commit into
mainfrom
fix/validationMenu
Apr 9, 2025
Merged

fix(validation): Update validationType handling#2685
Chartman123 merged 1 commit into
mainfrom
fix/validationMenu

Conversation

@Chartman123
Copy link
Copy Markdown
Collaborator

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 added the bug Something isn't working label Apr 8, 2025
@Chartman123 Chartman123 self-assigned this Apr 8, 2025
@Chartman123 Chartman123 added javascript Javascript related ticket high High priority labels Apr 8, 2025
@Chartman123 Chartman123 requested a review from hamza221 April 8, 2025 22:21
@Chartman123 Chartman123 added 3. to review Waiting for reviews regression Regression of a previous working feature labels Apr 8, 2025
@Chartman123 Chartman123 requested a review from susnux April 8, 2025 22:21
@Chartman123 Chartman123 changed the title Refactor(validation): Update validationType handling with getter/setter and simplify change logic fix(validation): Update validationType handling with getter/setter and simplify change logic Apr 8, 2025
Copy link
Copy Markdown
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works but not a fan of computed setters with API calls within

Comment thread src/components/Questions/QuestionShort.vue Outdated
Comment thread src/components/Questions/QuestionShort.vue Outdated
…er and simplify change logic

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 merged commit e6e71f6 into main Apr 9, 2025
47 checks passed
@Chartman123 Chartman123 deleted the fix/validationMenu branch April 9, 2025 17:26
@Chartman123
Copy link
Copy Markdown
Collaborator Author

/backport to stable4

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Apr 9, 2025
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Apr 9, 2025
@Chartman123 Chartman123 added this to the 5.2 milestone Apr 10, 2025
@Chartman123 Chartman123 changed the title fix(validation): Update validationType handling with getter/setter and simplify change logic fix(validation): Update validationType handling Apr 10, 2025
@Chartman123
Copy link
Copy Markdown
Collaborator Author

/backport to stable5

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Jun 25, 2025
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working high High priority javascript Javascript related ticket regression Regression of a previous working feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants