refactoring: move code to separate function storeAnswersForQuestion#1866
Merged
Chartman123 merged 1 commit intoJan 5, 2024
Conversation
tpokorra
force-pushed
the
TP-202401-refactoring_storeAnswersForQuestion
branch
2 times, most recently
from
81554b2 to
9698fb2
Compare
this helps in preparation for nextcloud#1110 Signed-off-by: Timotheus Pokorra <timotheus.pokorra@solidcharity.com>
tpokorra
force-pushed
the
TP-202401-refactoring_storeAnswersForQuestion
branch
from
9698fb2 to
f24a595
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
============================================
+ Coverage 44.59% 44.62% +0.02%
- Complexity 657 658 +1
============================================
Files 58 58
Lines 2592 2593 +1
============================================
+ Hits 1156 1157 +1
Misses 1436 1436 |
Chartman123
approved these changes
Jan 5, 2024
Chartman123
added
php
Collaborator
|
/backport to stable3 |
backportbot-nextcloud
Bot
added
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this helps in preparation for #1110
I am not ready to submit the pull request #1690 for issue #1110 yet, because I have not added new tests yet.
But rebasing is difficult with this refactoring.
Also it might make the review for the big pull request easier, if this small pull request is already done.