Skip to content

feat(e2e): add Playwright e2e tests for first-run wizard and settings page#2017

Open
Copilot wants to merge 1 commit intomasterfrom
copilot/setup-e2e-tests-for-firstrunwizard
Open

feat(e2e): add Playwright e2e tests for first-run wizard and settings page#2017
Copilot wants to merge 1 commit intomasterfrom
copilot/setup-e2e-tests-for-firstrunwizard

Conversation

Copy link

Copilot AI commented Mar 23, 2026

No description provided.

@szaimen szaimen added this to the Nextcloud 34 milestone Mar 23, 2026
Copilot AI requested a review from szaimen March 23, 2026 11:20
… page

Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/fead3c70-8ae9-4d07-9ab7-4a42f2bbeb6d

fix(e2e): use nextcloud-version-matrix to determine correct server branch

Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/c1e9236f-f665-4945-980b-77e53a8f025a

refactor: use @nextcloud/e2e-test-server for Docker-based e2e testing

Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/4928786f-c755-4bea-8c14-e5e1ae087ec3

fix(e2e): fix 3 failing test cases

- Fix App.vue to skip intro animation in changelog-only mode
- Fix 'can be navigated' test: NcButton primary variant has no CSS class
- Fix settings test: duplicate ID selector + add Skip button click
- Use --with-deps for Playwright install in CI

Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/57316464-f4c4-4f0c-85e3-87160d3bcd03

fix(e2e): revert App.vue changes, fix tests without app-level workarounds

- Revert src/views/App.vue to original state (always start at intro animation)
- Fix 'opens when a new major version' test: click Skip to advance past intro
- Move 'About & What's new' wizard test from settings.spec.ts to firstrunwizard.spec.ts
- Remove 'About & What's new' describe block from settings.spec.ts

Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/46619e35-ecf5-4089-a682-8830bd9abfe6

fix(e2e): fix setUserPreference to pass value as positional arg to occ user:setting

occ user:setting takes the value as a positional argument, not --value=VALUE.
The --value flag was silently ignored, so setUserPreference never actually set
the 'show' preference, causing the 'opens when a new major version was shipped'
test to always fail with the wizard landing on page 0 instead of the whats-new page.

Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/784a92c7-5c87-4afc-b355-9a4633cbe01d
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
@szaimen szaimen force-pushed the copilot/setup-e2e-tests-for-firstrunwizard branch from 7744d01 to 185870a Compare March 23, 2026 17:23
@szaimen szaimen removed their request for review March 23, 2026 17:34
@szaimen szaimen marked this pull request as ready for review March 23, 2026 17:34
@szaimen szaimen dismissed their stale review March 23, 2026 17:34

resolved

@szaimen
Copy link
Collaborator

szaimen commented Mar 23, 2026

This is ready for review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants