feat(e2e): add Playwright e2e tests for first-run wizard and settings page#2017
Open
feat(e2e): add Playwright e2e tests for first-run wizard and settings page#2017
Conversation
Copilot created this pull request from a session on behalf of
szaimen
March 23, 2026 11:11
View session
Copilot stopped work on behalf of
szaimen due to an error
March 23, 2026 11:38
Copilot stopped work on behalf of
szaimen due to an error
March 23, 2026 11:48
Copilot stopped work on behalf of
szaimen due to an error
March 23, 2026 15:37
szaimen
previously requested changes
Mar 23, 2026
… page Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/fead3c70-8ae9-4d07-9ab7-4a42f2bbeb6d fix(e2e): use nextcloud-version-matrix to determine correct server branch Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/c1e9236f-f665-4945-980b-77e53a8f025a refactor: use @nextcloud/e2e-test-server for Docker-based e2e testing Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/4928786f-c755-4bea-8c14-e5e1ae087ec3 fix(e2e): fix 3 failing test cases - Fix App.vue to skip intro animation in changelog-only mode - Fix 'can be navigated' test: NcButton primary variant has no CSS class - Fix settings test: duplicate ID selector + add Skip button click - Use --with-deps for Playwright install in CI Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/57316464-f4c4-4f0c-85e3-87160d3bcd03 fix(e2e): revert App.vue changes, fix tests without app-level workarounds - Revert src/views/App.vue to original state (always start at intro animation) - Fix 'opens when a new major version' test: click Skip to advance past intro - Move 'About & What's new' wizard test from settings.spec.ts to firstrunwizard.spec.ts - Remove 'About & What's new' describe block from settings.spec.ts Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/46619e35-ecf5-4089-a682-8830bd9abfe6 fix(e2e): fix setUserPreference to pass value as positional arg to occ user:setting occ user:setting takes the value as a positional argument, not --value=VALUE. The --value flag was silently ignored, so setUserPreference never actually set the 'show' preference, causing the 'opens when a new major version was shipped' test to always fail with the wizard landing on page 0 instead of the whats-new page. Agent-Logs-Url: https://github.com/nextcloud/firstrunwizard/sessions/784a92c7-5c87-4afc-b355-9a4633cbe01d Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
7744d01 to
185870a
Compare
Collaborator
|
This is ready for review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.