feat(config): switch to config lexicon#1060
Open
ArtificialOwl wants to merge 1 commit intomainfrom
Open
Conversation
ArtificialOwl
force-pushed
the
feat/noid/configlexicon
branch
from
e0f6c40 to
0515072
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
feat/noid/configlexicon
branch
from
0515072 to
14fbe74
Compare
ArtificialOwl
requested review from
benjaminfrueh and
juliusknorr
as code owners
Contributor
benjaminfrueh
left a comment
benjaminfrueh
left a comment
There was a problem hiding this comment.
@ArtificialOwl I think this change is missing the registration of the ConfigLexicon in the Application.php- I was testing the feature and always get 0 for the lock_timeout- and then also ttl=0 in the database.
$context->registerConfigLexicon(ConfigLexicon::class);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.