perf: cache negative results in LockSerivice::getLockForNodeIds

[icewind1991]

Currently it only stores results in the cache if the file has a lock, meaning that getLockForNodeIds still ends up doing a query for every file without a lock.

[icewind1991]

/backport to stable33

[benjaminfrueh]

@icewind1991 If we prefill the $lockCache with false, it currently breaks the federation, as getLockForNodeId() will return early then and not call getRemoteLockFromDav().

One way to deal with this, would be to also call getRemoteLockFromDav() in getLockForNodeIds() for every file without a local lock and add it to the cache. getRemoteLockFromDav() returns early for non-DAV storages.

What do you think, how should we best deal with this, to make it work with federation?

[icewind1991]

It probably makes sense to cache the local and federated locks separately.

Federated locks also currently have the problem of loading the locks one by one instead of doing a single propfind to load the locks for an entire folder at once.

[benjaminfrueh]

It probably makes sense to cache the local and federated locks separately.

Federated locks also currently have the problem of loading the locks one by one instead of doing a single propfind to load the locks for an entire folder at once.

As discussed I will work on these changes.