docs(admin): rewrite deleted files configuration chapter - #15421
Open
joshtrichards wants to merge 2 commits into
Open
docs(admin): rewrite deleted files configuration chapter#15421joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Update, expand, and clarify trash-bin retention policies, size limits, interactions with quotas, background jobs details, and the various commands based on the current files_trashbin implementation. Assisted-by: Copilot:gpt-5.6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
marked this pull request as ready for review
August 7, 2026 17:12
Contributor
|
Thanks a lot! I'd just a had a chat about this page the other day because some of the information are outdated. Louis reworked https://docs.nextcloud.com/server/stable/admin_manual/configuration_server/config_sample_php_parameters.html#deleted-items-trash-bin recently. What do you think about moving the enhanced documention for trashbin_retention_obligation over to the config.sample.php and set a backlink here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Rewrites the admin-facing trash bin / deleted files chapter to align it with the current
files_trashbinimplementation.The existing chapter is outdated and incomplete: it does not document the trash-bin size mechanism (50% of remaining quota space, or available filesystem space for accounts without a quota), omits
trashbin:size,trashbin:cleanup, andtrashbin:restore, and describes the retention-policy values (auto,D1, auto,auto, D2,D1, D2, and bare numeric values) imprecisely, particularly regarding space-triggered cleanup andD1/D2clamping. Background-job cadence and which policies trigger a time-based expiration pass were also not documented.Changes:
trashbin_retention_obligationvalue, including its interaction with space-triggered cleanup.occ trashbin:size, global versus per-account precedence, and the 50%-of-remaining-quota default, with available filesystem space used for accounts without a quota.trashbin:expire,trashbin:cleanup, andtrashbin:restore, including--all-usersversus user-ID handling and the--since,--until,--scope, and--dry-runoptions.The documented behavior was checked directly against the relevant implementation rather than carried over from the previous documentation.
Separately, a minor wording issue was identified in the
occ trashbin:expireoutput for the disabled-retention case. That's a code fix, not a docs one, and will be addressed separately.🖼️ Screenshots
See generated preview when CI completes.
✅ Checklist
codespellor similar and addressed any spelling issues