feat: migrate Windows build scripts from client-building to PowerShell in admin/win#9871
Draft
feat: migrate Windows build scripts from client-building to PowerShell in admin/win#9871
Conversation
…to PS1 Agent-Logs-Url: https://github.com/nextcloud/desktop/sessions/c407964d-dd56-4ecf-8f3b-6d3a13b7ad4c Co-authored-by: mgallien <168967+mgallien@users.noreply.github.com>
Agent-Logs-Url: https://github.com/nextcloud/desktop/sessions/c407964d-dd56-4ecf-8f3b-6d3a13b7ad4c Co-authored-by: mgallien <168967+mgallien@users.noreply.github.com>
Agent-Logs-Url: https://github.com/nextcloud/desktop/sessions/c407964d-dd56-4ecf-8f3b-6d3a13b7ad4c Co-authored-by: mgallien <168967+mgallien@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mgallien
April 20, 2026 15:47
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the Windows build pipeline from the external
nextcloud/client-buildingbatch scripts into this repository as PowerShell, living inadmin/win/build/. Also convertsadmin/win/msi/make-msi.bat.into PowerShell.Changes
admin/win/build/— new PowerShell build pipelinecommon.ps1common.inc.bat/datetime.inc.batInvoke-NativeCommand,Invoke-VsDevShell,Invoke-Sign,Invoke-Upload,Write-BuildStepdefaults.ps1defaults.inc.batinit.ps1init.batbuild.ps1build.batbuild-desktop.ps1build-desktop.bat+single-build-desktop.batBUILD_TARGETSbuild-installer-collect.ps1build-installer-collect.bat+ single variantbuild-installer-msi.ps1build-installer-msi.bat+ single variantmake-msi.ps1, signs + moves + uploads the MSIsign.ps1sign.batInvoke-Signupload.ps1upload.batInvoke-Uploadtask-build-log.ps1task-build-log.batStart-Transcript; exits with build exit codeREADME.mdNSIS installer workflow is intentionally not carried forward; MSI is the sole Windows installer format.
admin/win/msi/make-msi.ps1.in— newDirect PowerShell port of
make-msi.bat.in. Replaces!LF!/setlocal EnableDelayedExpansiontricks with clean loops and[System.Guid]::NewGuid()instead ofuuidgen.admin/win/msi/CMakeLists.txt— updatedSwitches
configure_filetarget frommake-msi.bat.in→make-msi.ps1.inand updates theinstall(FILES …)list accordingly.Notes
TEST_RUN=1dry-run mode is preserved across all scripts.