Fix login flow by avoiding manual redirect policy on macOS client#9861
Fix login flow by avoiding manual redirect policy on macOS client#9861KarstenH792 wants to merge 1 commit intonextcloud:masterfrom
Conversation
Signed-off-by: Karsten Hoehn <git@karstenhoehn.net>
8c455b4 to
7ff9f54
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Just checking if someone could take a quick look at this. The fix has been tested locally and resolves the login issue for me. Happy to adjust if needed. |
Summary
Fix login flow by changing redirect handling from
ManualRedirectPolicytoNoLessSafeRedirectPolicyinsrc/libsync/accessmanager.cpp.Problem
The current desktop client fails during account setup/login with a redirect-related error, while:
Fix
Replace:
QNetworkRequest::ManualRedirectPolicy
with:
QNetworkRequest::NoLessSafeRedirectPolicy
Result
With this change:
Additional context
This appears to be a regression compared to 4.0.2.
Related issue
Fixes #9794