Skip to content

Conversation

@Rello
Copy link
Collaborator

@Rello Rello commented Feb 5, 2026

Motivation

  • The sync status overlay on the avatar conflicted with the user presence indicator and was visually confusing.
  • Sync attention indicators should be scanable in the account list and not obscure the avatar, and the menu needs a bit more width to accommodate an extra column.

Description

  • Moved the per-account sync indicator out of the avatar overlay into a dedicated right-aligned column in each account row by updating src/gui/tray/UserLine.qml to add a syncStatusColumn that reserves space even when empty.
  • Increased the account menu width budget in src/gui/tray/CurrentAccountHeaderButton.qml by adding an extraMenuWidth so rows do not get cramped.
  • Added syncStatusIcon and syncStatusOk properties to User and new roles SyncStatusIconRole/SyncStatusOkRole in UserModel (src/gui/tray/usermodel.h / src/gui/tray/usermodel.cpp).
  • Implemented sync status computation in usermodel.cpp with determineSyncStatus and syncStatusForAccount, mapping folder sync results to theme icons (ok, error, warning, pause, sync, offline) and wired FolderMan/AccountState signals to call updateSyncStatus() and emit model changes.

Testing

  • No automated unit or integration tests were executed for this QML layout and model change.
  • An attempt to capture a visual verification via a headless browser script failed due to no local UI target being available (ERR_EMPTY_RESPONSE).
  • Basic runtime/format checks were used during development but no automated build or CI tests were run on the modified code.

Codex Task

Signed-off-by: Rello <Rello@users.noreply.github.com>
@Rello Rello marked this pull request as draft February 5, 2026 10:45
@Rello Rello changed the title fix: move per-account sync indicator into right-aligned account column feat(tray): sync status indicator in account menu Feb 5, 2026
@Rello Rello moved this to 🏗️ In progress in 💻 Desktop Clients team Feb 5, 2026
@Rello Rello added 3. to review design Design, UI, UX, etc. labels Feb 5, 2026
@Rello Rello added this to the 33.0.0 milestone Feb 5, 2026
@Rello Rello self-assigned this Feb 6, 2026
Rello added 12 commits February 9, 2026 14:55
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
Signed-off-by: Rello <Rello@users.noreply.github.com>
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9427.zip

Digest: sha256:63e08abd54a752fe8a5264c74fc19e75faa2da1eacf594897fd07358e3f50f4b

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)
41 New Code Smells (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

1 participant