fix: build error with OpenSSL 4.0#10222
Closed
raviksharma wants to merge 1 commit into
Closed
Conversation
raviksharma
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
X509_REQ_get_subject_name() now returns const X509_NAME * in OpenSSL 4.0. Per the OpenSSL migration guide, create a mutable X509_NAME, populate it, and set it on the request with X509_REQ_set_subject_name(). Fixes https://bugs.launchpad.net/ubuntu/+source/nextcloud-desktop/+bug/2154940
raviksharma
force-pushed
the
fix-openssl4-compat
branch
from
31c66cd to
cc14ec2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X509_REQ_get_subject_name() now returns
const X509_NAME *in OpenSSL 4.0, causing a build error. const_cast since the name is mutated via X509_NAME_add_entry_by_txt.Fixes https://bugs.launchpad.net/ubuntu/+source/nextcloud-desktop/+bug/2154940