Skip to content

feat: allow read-only users to assign labels to cards (#590) #7940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guangningsun wants to merge 1 commit into
base: main
Choose a base branch
from
+66 −1
Open

feat: allow read-only users to assign labels to cards (#590) #7940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Service/CardService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ public function undone(int $id): Card {
public function assignLabel(int $cardId, int $labelId): Card {
$this->cardServiceValidator->check(compact('cardId', 'labelId'));

$this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_EDIT);
$this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_READ);
$this->permissionService->checkPermission($this->labelMapper, $labelId, Acl::PERMISSION_READ);

if ($this->boardService->isArchived($this->cardMapper, $cardId)) {
Expand Down
65 changes: 65 additions & 0 deletions tests/unit/Service/CardServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@
namespace OCA\Deck\Service;

use OCA\Deck\Activity\ActivityManager;
use OCA\Deck\Db\Acl;
use OCA\Deck\Db\Assignment;
use OCA\Deck\Db\AssignmentMapper;
use OCA\Deck\NoPermissionException;
use OCA\Deck\Db\Board;
use OCA\Deck\Db\BoardMapper;
use OCA\Deck\Db\Card;
Expand Down Expand Up @@ -549,6 +551,69 @@ public function testRemoveLabelArchived() {
$this->cardService->removeLabel(123, 999);
}

public function testAssignLabelWithReadPermission() {
// Users with READ permission (but not EDIT) should be able to assign labels
// This allows read-only users to label cards they are assigned to
$card = new Card();
$card->setArchived(false);
$card->setId(123);
$label = new Label();
$label->setBoardId(1);

$this->permissionService->expects($this->exactly(2))
->method('checkPermission')
->willReturn(true);
$this->cardMapper->expects($this->once())->method('find')->willReturn($card);
$this->cardMapper->expects($this->once())->method('assignLabel');
$this->cardMapper->expects($this->once())
->method('findBoardId')
->willReturn(1);
$this->labelMapper->expects($this->once())
->method('find')
->willReturn($label);
$this->cardService->assignLabel(123, 999);
}

public function testAssignLabelWithoutReadPermission() {
// Users without READ permission should get NoPermissionException
$this->permissionService->expects($this->once())
->method('checkPermission')
->willThrowException(new NoPermissionException('Permission denied'));
$this->cardMapper->expects($this->never())->method('assignLabel');
$this->expectException(NoPermissionException::class);
$this->cardService->assignLabel(123, 999);
}

public function testRemoveLabelRequiresEditPermission() {
// Removing a label requires EDIT permission (higher than READ)
// This is intentional: read-only users can add labels but not remove them
$card = new Card();
$card->setArchived(false);
$card->setId(123);
$label = new Label();
$label->setBoardId(1);

$this->permissionService->expects($this->exactly(2))
->method('checkPermission')
->willReturn(true);
$this->cardMapper->expects($this->once())->method('find')->willReturn($card);
$this->cardMapper->expects($this->once())->method('removeLabel');
$this->labelMapper->expects($this->once())
->method('find')
->willReturn($label);
$this->cardService->removeLabel(123, 999);
}

public function testRemoveLabelWithoutEditPermission() {
// Without EDIT permission, removing a label should fail
$this->permissionService->expects($this->once())
->method('checkPermission')
->willThrowException(new NoPermissionException('Permission denied'));
$this->cardMapper->expects($this->never())->method('removeLabel');
$this->expectException(NoPermissionException::class);
$this->cardService->removeLabel(123, 999);
}

public function testDoneMarksCardAsDone(): void {
$card = new Card();
$card->setId(42);
Expand Down