Skip to content

chore: removing unused properties about org chart - #5646

Open
madbob wants to merge 1 commit into
nextcloud:mainfrom
madbob:org_minor_fixes
Open

chore: removing unused properties about org chart#5646
madbob wants to merge 1 commit into
nextcloud:mainfrom
madbob:org_minor_fixes

Conversation

@madbob

@madbob madbob commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Some minor changes related to the Org Chart:

  • fixed the missing reference to logger (recently introduced in chore(lint): dont allow console calls #5624)
  • removed unused properties introduced in Add organization charts #2954. It seems the intention was to bubble the full list of contacts from ContactsContent to ContactDetailsProperty probably to permit cross-contacts references, then the otherContacts mixin's function has been used to draw directly from $store.getters.getSortedContacts (this is my own speculation!). I've tested the Chart panel and it works also without those properties (apart for Adding line manager property does not work #4454, which has already been fixed but not yet merged in main)

Signed-off-by: Roberto Guido <info@madbob.org>
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/AppContent/ContactsContent.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant