chore: implement rs pack - #5632
Open
SebastianKrupinski wants to merge 1 commit into
Open
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
chore/rspack
branch
from
August 9, 2026 17:55
6a24a2e to
c85e4bc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
odzhychko
approved these changes
Aug 16, 2026
odzhychko
left a comment
odzhychko
left a comment
There was a problem hiding this comment.
Tested the entry points. They work as expected.
package-lock.json needs to be remade.
| }), | ||
| new CssExtractRspackPlugin({ | ||
| filename: '../css/contacts-[name].css', | ||
| chunkFilename: '../css/[id].chunk.css', |
There was a problem hiding this comment.
Suggested change
| chunkFilename: '../css/[id].chunk.css', | |
| chunkFilename: '../css/chunks/[id].chunk.css', |
nit(non-blocking): To be consistent with https://github.com/nextcloud/calendar/blob/fb819ae3762048fe6c5069b48dd2008bb311fd07/rspack.config.js#L233
There was a problem hiding this comment.
issue: For some reason resolved and integrity are missing.
Maybe because private registry/cache/proxy where used when installing.
Can be fixed by running npx npm-package-lock-add-resolved.
Anyway conflicting package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Results
Before:
Compile time: 11.5s
Compile size: 3.3mb
After:
Compile time: 4.2s
Compile size: 3.09mb