Skip to content

fix(contacts): correctly insert contacts into sorted list - #5626

Open
triantos wants to merge 1 commit into
nextcloud:mainfrom
triantos:fix/contact-sorted-insertion
Open

fix(contacts): correctly insert contacts into sorted list#5626
triantos wants to merge 1 commit into
nextcloud:mainfrom
triantos:fix/contact-sorted-insertion

Conversation

@triantos

@triantos triantos commented Aug 8, 2026

Copy link
Copy Markdown

Summary

  • use the existing favorite-and-name comparator to find the correct linear insertion point
  • append new contacts when no later item exists
  • add regression coverage for beginning, middle, end, and favorite ordering using Nextcloudy McCloudface as a fixture

Problem

The previous insertion loop could omit a newly created contact from sortedContacts when it sorted before every existing entry. It could also place contacts incorrectly in the middle or across favorite boundaries. Because the new contact was absent from the sorted list, navigation could immediately report “Contact not found” after creating it.

Tests

  • npm test -- --runInBand (29 tests pass)
  • npm run lint -- --quiet
  • npm run build

Use the existing favorite-and-name comparator to find the insertion point and cover beginning, middle, end, and favorite ordering.

Assisted-by: Codex:gpt-5
Signed-off-by: Nick Triantos <nick@triantos.com>
@triantos
triantos force-pushed the fix/contact-sorted-insertion branch from 04769bb to 8c22afe Compare August 8, 2026 01:58
@DerDreschner DerDreschner added bug Something isn't working 3. to review Waiting for reviews labels Aug 13, 2026
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants