fix(contacts): correctly insert contacts into sorted list - #5626
Conversation
Use the existing favorite-and-name comparator to find the insertion point and cover beginning, middle, end, and favorite ordering. Assisted-by: Codex:gpt-5 Signed-off-by: Nick Triantos <nick@triantos.com>
04769bb to
8c22afe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Problem
The previous insertion loop could omit a newly created contact from
sortedContactswhen it sorted before every existing entry. It could also place contacts incorrectly in the middle or across favorite boundaries. Because the new contact was absent from the sorted list, navigation could immediately report “Contact not found” after creating it.Tests
npm test -- --runInBand(29 tests pass)npm run lint -- --quietnpm run build