feat: implement doctrine-based fulltext search#2118
Conversation
07cbae6 to
d8a4b06
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
mejo-
left a comment
There was a problem hiding this comment.
Really nice work, thanks so much @benjaminfrueh. I finally found time to go through the code changes, read up a bit on stemming, fuzzy searching, bigrams and other stuff I didn't know much about before 😆
The general approach of your implementation looks really clean and promising to me.
I have quite a few comments and questions and am curious what you think about them.
d8a4b06 to
b26823e
Compare
b26823e to
2ee83e2
Compare
bfd5805 to
14cf7c2
Compare
7e969f2 to
3474638
Compare
6e9453d to
83f65aa
Compare
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
No longer needed with new search backend. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
Signed-off-by: Jonas <jonas@freesources.org>
83f65aa to
11088c1
Compare
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
fac7561 to
ef4e5e3
Compare
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
ef4e5e3 to
0b72e7a
Compare
mejo-
left a comment
There was a problem hiding this comment.
Really nice work, thanks @benjaminfrueh ❤️
📝 Summary
Replaces TNTSearch with nextcloud database full-text search using doctrine.
Resolves #2050
Todo
php-stemmerdependency usingphp-scoper🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)