feat(calendar): plural default calendar reminders#8567
Open
rich0 wants to merge 1 commit into
Open
Conversation
This was referenced Jul 5, 2026
rich0
force-pushed
the
upstreampr/pluralcalendardefaults
branch
from
291bbf9 to
69d675d
Compare
Add multi-alarm list editors in Edit Calendar settings for part-day and full-day default reminders, mirroring the event alarm editor pattern. Reads and writes plural CalDAV properties via update to cdav-library. - NC34: legacy single-dropdown UI unchanged - NC35+: DefaultAlarmsList with relative triggers and DISPLAY/EMAIL Assisted-by: Grok:grok-4 Signed-off-by: Richard Freeman <rich@rich0.org>
rich0
force-pushed
the
upstreampr/pluralcalendardefaults
branch
from
69d675d to
2c5ec60
Compare
rich0
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is hand-written (other than the commit comment below, which was edited by me), but the code changes were created by AI.
I am a novice at PHP and new to Nextcloud development so I invite scrutiny. I noted questions about nextcloud dev conventions below. Everything was reviewed and tested by me with both the stable server and the new app+lib, plus the stable app and the new server.
The intent of this feature is to extend the recent default calendar reminder feature by allowing multiple reminders to be set as well as the notification type for each. Only relative reminder intervals are supported as I didn't think absolute reminders made much sense in a template. This requires changes in server, cdav-library, and the calendar app.
The server revisions are backwards-compatible with the current stable app, and the app revisions are backwards-compatible with the current stable server. In the app the UI reflects a pre-v34 server, v34 (existing defaults functionality) and v35+ (new functionality). I'll describe server-side compatibility in the server PR.
The calendar app has a dependency on the updated cdav-library, which is not reflected in package.json as I'm not sure what the convention is for bumping these revisions in tandem.
This is related to:
nextcloud/cdav-library#1066
nextcloud/server#61832
Commit comment:
Add multi-alarm list editors in Edit Calendar settings for part-day and full-day default reminders, mirroring the event alarm editor pattern. Reads and writes plural CalDAV properties via update to cdav-library.
Assisted-by: Grok:grok-4
🤖 AI (if applicable)