Skip to content

fix: exoplayer usage #16603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alperozturk96 wants to merge 5 commits into
base: master
Choose a base branch
from
+292 −197
Open

fix: exoplayer usage #16603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d90c162
fix(exo-player): service not start in time
alperozturk96 Feb 27, 2026
e2a45bb
fix(exo-player): service not start in time
alperozturk96 Feb 27, 2026
1e805ed
fix(exo-player): illegal state exception creation of exoplayer
alperozturk96 Feb 27, 2026
a003a5c
fix(exo-player): crash
alperozturk96 Feb 27, 2026
3796736
fix(exo-player): crash
alperozturk96 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
287 changes: 170 additions & 117 deletions app/src/main/java/com/nextcloud/client/media/BackgroundPlayerService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/*
* Nextcloud - Android Client
*
* SPDX-FileCopyrightText: 2026 Alper Ozturk <alper.ozturk@nextcloud.com>
* SPDX-FileCopyrightText: 2024 Parneet Singh <gurayaparneet@gmail.com>
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
Expand All @@ -12,8 +13,12 @@ import android.content.BroadcastReceiver
import android.content.Context
import android.content.Intent
import android.content.IntentFilter
import android.content.pm.ServiceInfo
import android.os.Build
import android.os.Bundle
import androidx.annotation.OptIn
import androidx.core.app.NotificationCompat
import androidx.core.app.ServiceCompat
import androidx.media3.common.Player
import androidx.media3.common.Player.COMMAND_PLAY_PAUSE
import androidx.media3.common.Player.COMMAND_SEEK_TO_NEXT
Expand Down Expand Up @@ -41,9 +46,15 @@ import com.nextcloud.client.network.ClientFactory
import com.nextcloud.common.NextcloudClient
import com.nextcloud.utils.extensions.registerBroadcastReceiver
import com.owncloud.android.MainApp
import com.owncloud.android.R
import com.owncloud.android.datamodel.ReceiverFlag
import com.owncloud.android.lib.common.utils.Log_OC
import com.owncloud.android.ui.notifications.NotificationUtils
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.cancel
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
import javax.inject.Inject

Expand All @@ -52,45 +63,86 @@ class BackgroundPlayerService :
MediaSessionService(),
Injectable {

private val serviceScope = CoroutineScope(SupervisorJob() + Dispatchers.Main)

private val seekBackSessionCommand = SessionCommand(SESSION_COMMAND_ACTION_SEEK_BACK, Bundle.EMPTY)
private val seekForwardSessionCommand = SessionCommand(SESSION_COMMAND_ACTION_SEEK_FORWARD, Bundle.EMPTY)

val seekForward =
CommandButton.Builder()
.setDisplayName("Seek Forward")
.setIconResId(CommandButton.getIconResIdForIconConstant(CommandButton.ICON_SKIP_FORWARD_15))
.setSessionCommand(seekForwardSessionCommand)
.setExtras(Bundle().apply { putInt(COMMAND_KEY_COMPACT_VIEW_INDEX, 2) })
.build()

val seekBackward =
CommandButton.Builder()
.setDisplayName("Seek Backward")
.setIconResId(CommandButton.getIconResIdForIconConstant(CommandButton.ICON_SKIP_BACK_5))
.setSessionCommand(seekBackSessionCommand)
.setExtras(Bundle().apply { putInt(COMMAND_KEY_COMPACT_VIEW_INDEX, 0) })
.build()
private lateinit var seekForward: CommandButton
private lateinit var seekBackward: CommandButton

@Inject
lateinit var clientFactory: ClientFactory

@Inject
lateinit var userAccountManager: UserAccountManager
lateinit var exoPlayer: ExoPlayer

private lateinit var exoPlayer: ExoPlayer
private var mediaSession: MediaSession? = null
private var isPlayerReady = false

private val stopReceiver = object : BroadcastReceiver() {
override fun onReceive(context: Context?, intent: Intent?) {
when (intent?.action) {
RELEASE_MEDIA_SESSION_BROADCAST_ACTION -> release()
STOP_MEDIA_SESSION_BROADCAST_ACTION -> exoPlayer.stop()

STOP_MEDIA_SESSION_BROADCAST_ACTION -> {
if (isPlayerReady) {
exoPlayer.stop()
} else {
stopSelf()
}
}
}
}
}

override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int {
val notification = NotificationCompat.Builder(this, NotificationUtils.NOTIFICATION_CHANNEL_MEDIA)
.setSmallIcon(R.drawable.logo)
.setContentTitle(getString(R.string.media_player_playing))
.setSilent(true)
.build()

ServiceCompat.startForeground(
this,
DefaultMediaNotificationProvider.DEFAULT_NOTIFICATION_ID,
notification,
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
ServiceInfo.FOREGROUND_SERVICE_TYPE_MEDIA_PLAYBACK
} else {
0
}
)

return super.onStartCommand(intent, flags, startId)
}

@Suppress("DEPRECATION")
override fun onCreate() {
super.onCreate()

MainApp.getAppComponent().inject(this)

seekForward = CommandButton.Builder()
.setDisplayName(getString(R.string.media_player_seek_forward))
.setIconResId(R.drawable.ic_skip_next)
.setSessionCommand(seekForwardSessionCommand)
.setExtras(Bundle().apply { putInt(COMMAND_KEY_COMPACT_VIEW_INDEX, 2) })
.build()

seekBackward = CommandButton.Builder()
.setDisplayName(getString(R.string.media_player_seek_backward))
.setIconResId(R.drawable.ic_skip_previous)
.setSessionCommand(seekBackSessionCommand)
.setExtras(Bundle().apply { putInt(COMMAND_KEY_COMPACT_VIEW_INDEX, 0) })
.build()

exoPlayer = ExoPlayer.Builder(this).build()
mediaSession = buildMediaSession(exoPlayer)

setMediaNotificationProvider(buildNotificationProvider())

registerBroadcastReceiver(
stopReceiver,
IntentFilter().apply {
Expand All @@ -100,100 +152,101 @@ class BackgroundPlayerService :
ReceiverFlag.NotExported
)

MainApp.getAppComponent().inject(this)
initNextcloudExoPlayer()
initExoPlayer()
}

setMediaNotificationProvider(object : DefaultMediaNotificationProvider(this) {
override fun getMediaButtons(
session: MediaSession,
playerCommands: Player.Commands,
customLayout: ImmutableList<CommandButton>,
showPauseButton: Boolean
): ImmutableList<CommandButton> {
val playPauseButton =
CommandButton.Builder()
.setDisplayName("PlayPause")
.setIconResId(
CommandButton.getIconResIdForIconConstant(
if (mediaSession?.player?.isPlaying == true) {
CommandButton.ICON_PAUSE
} else {
CommandButton.ICON_PLAY
}
)
)
.setPlayerCommand(COMMAND_PLAY_PAUSE)
.setExtras(Bundle().apply { putInt(COMMAND_KEY_COMPACT_VIEW_INDEX, 1) })
.build()

val myCustomButtonsLayout =
ImmutableList.of(seekBackward, playPauseButton, seekForward)
return myCustomButtonsLayout
@Suppress("TooGenericExceptionCaught")
private fun initExoPlayer() {
serviceScope.launch {
try {
val nextcloudClient: NextcloudClient = withContext(Dispatchers.IO) {
clientFactory.createNextcloudClient(userAccountManager.user)
}

val realPlayer = createNextcloudExoplayer(this@BackgroundPlayerService, nextcloudClient)
exoPlayer.release()
exoPlayer = realPlayer
isPlayerReady = true

// Update the session to use the real player
mediaSession?.player = realPlayer
} catch (e: Exception) {
Log_OC.e(TAG, "Failed to initialise Nextcloud ExoPlayer: ${e.message}")
stopSelf()
}
})
}
}

private fun initNextcloudExoPlayer() {
runBlocking {
var nextcloudClient: NextcloudClient
withContext(Dispatchers.IO) {
nextcloudClient = clientFactory.createNextcloudClient(userAccountManager.user)
private fun buildMediaSession(player: ExoPlayer): MediaSession = MediaSession.Builder(applicationContext, player)
.setId(BACKGROUND_MEDIA_SESSION_ID)
.setCustomLayout(listOf(seekBackward, seekForward))
.setCallback(object : MediaSession.Callback {
override fun onConnect(session: MediaSession, controller: MediaSession.ControllerInfo): ConnectionResult =
AcceptedResultBuilder(mediaSession ?: session)
.setAvailablePlayerCommands(
ConnectionResult.DEFAULT_PLAYER_COMMANDS.buildUpon()
.remove(COMMAND_SEEK_TO_NEXT)
.remove(COMMAND_SEEK_TO_NEXT_MEDIA_ITEM)
.remove(COMMAND_SEEK_TO_PREVIOUS)
.remove(COMMAND_SEEK_TO_PREVIOUS_MEDIA_ITEM)
.build()
)
.setAvailableSessionCommands(
ConnectionResult.DEFAULT_SESSION_COMMANDS.buildUpon()
.addSessionCommands(
listOf(seekBackSessionCommand, seekForwardSessionCommand)
).build()
)
.build()

override fun onPostConnect(session: MediaSession, controller: MediaSession.ControllerInfo) {
session.setCustomLayout(listOf(seekBackward, seekForward))
}
nextcloudClient.let {
exoPlayer = createNextcloudExoplayer(this@BackgroundPlayerService, nextcloudClient)
mediaSession =
MediaSession.Builder(applicationContext, exoPlayer)
// set id to distinct this session to avoid crash
// in case session release delayed a bit and
// we start another session for eg. video
.setId(BACKGROUND_MEDIA_SESSION_ID)
.setCustomLayout(listOf(seekBackward, seekForward))
.setCallback(object : MediaSession.Callback {
override fun onConnect(
session: MediaSession,
controller: MediaSession.ControllerInfo
): ConnectionResult = AcceptedResultBuilder(mediaSession!!)
.setAvailablePlayerCommands(
ConnectionResult.DEFAULT_PLAYER_COMMANDS.buildUpon()
.remove(COMMAND_SEEK_TO_NEXT)
.remove(COMMAND_SEEK_TO_NEXT_MEDIA_ITEM)
.remove(COMMAND_SEEK_TO_PREVIOUS)
.remove(COMMAND_SEEK_TO_PREVIOUS_MEDIA_ITEM)
.build()
)
.setAvailableSessionCommands(
ConnectionResult.DEFAULT_SESSION_COMMANDS.buildUpon()
.addSessionCommands(
listOf(seekBackSessionCommand, seekForwardSessionCommand)
).build()
)
.build()

override fun onPostConnect(session: MediaSession, controller: MediaSession.ControllerInfo) {
session.setCustomLayout(listOf(seekBackward, seekForward))
}

override fun onCustomCommand(
session: MediaSession,
controller: MediaSession.ControllerInfo,
customCommand: SessionCommand,
args: Bundle
): ListenableFuture<SessionResult> = when (customCommand.customAction) {
SESSION_COMMAND_ACTION_SEEK_FORWARD -> {
session.player.seekForward()
Futures.immediateFuture(SessionResult(SessionResult.RESULT_SUCCESS))
}

SESSION_COMMAND_ACTION_SEEK_BACK -> {
session.player.seekBack()
Futures.immediateFuture(SessionResult(SessionResult.RESULT_SUCCESS))
}

else -> super.onCustomCommand(session, controller, customCommand, args)
}
})
.build()

override fun onCustomCommand(
session: MediaSession,
controller: MediaSession.ControllerInfo,
customCommand: SessionCommand,
args: Bundle
): ListenableFuture<SessionResult> = when (customCommand.customAction) {
SESSION_COMMAND_ACTION_SEEK_FORWARD -> {
session.player.seekForward()
Futures.immediateFuture(SessionResult(SessionResult.RESULT_SUCCESS))
}

SESSION_COMMAND_ACTION_SEEK_BACK -> {
session.player.seekBack()
Futures.immediateFuture(SessionResult(SessionResult.RESULT_SUCCESS))
}

else -> super.onCustomCommand(session, controller, customCommand, args)
}
})
.build()

private fun buildNotificationProvider() = object : DefaultMediaNotificationProvider(this) {
@Suppress("DEPRECATION")
override fun getMediaButtons(
session: MediaSession,
playerCommands: Player.Commands,
customLayout: ImmutableList<CommandButton>,
showPauseButton: Boolean
): ImmutableList<CommandButton> {
val isPlaying = mediaSession?.player?.isPlaying == true
val playPauseButton = CommandButton.Builder()
.setDisplayName(
if (isPlaying) {
getString(R.string.media_player_pause)
} else {
getString(R.string.media_player_play)
}
)
.setIconResId(if (isPlaying) R.drawable.ic_pause else R.drawable.ic_play_arrow)
.setPlayerCommand(COMMAND_PLAY_PAUSE)
.setExtras(Bundle().apply { putInt(COMMAND_KEY_COMPACT_VIEW_INDEX, 1) })
.build()

return ImmutableList.of(seekBackward, playPauseButton, seekForward)
}
}

Expand All @@ -203,6 +256,7 @@ class BackgroundPlayerService :

override fun onDestroy() {
unregisterReceiver(stopReceiver)
serviceScope.cancel()
mediaSession?.run {
player.release()
release()
Expand All @@ -214,28 +268,27 @@ class BackgroundPlayerService :
private fun release() {
val player = mediaSession?.player
if (player?.playWhenReady == true) {
// Make sure the service is not in foreground.
player.pause()
}
// Bug in Android 14, https://github.com/androidx/media/issues/805
// that sometimes onTaskRemove() doesn't get called immediately
// eventually gets called so the service stops but the notification doesn't clear out.
// [WORKAROUND] So, explicitly removing the notification here.
// TODO revisit after bug solved!
val nm = getSystemService(NOTIFICATION_SERVICE) as NotificationManager
nm.cancel(DefaultMediaNotificationProvider.DEFAULT_NOTIFICATION_ID)
stopForeground(STOP_FOREGROUND_REMOVE)
stopSelf()
}

override fun onGetSession(p0: MediaSession.ControllerInfo): MediaSession? = mediaSession
override fun onGetSession(controllerInfo: MediaSession.ControllerInfo): MediaSession? = mediaSession

companion object {
private val TAG = BackgroundPlayerService::class.java.simpleName

private const val SESSION_COMMAND_ACTION_SEEK_BACK = "SESSION_COMMAND_ACTION_SEEK_BACK"
private const val SESSION_COMMAND_ACTION_SEEK_FORWARD = "SESSION_COMMAND_ACTION_SEEK_FORWARD"
private const val BACKGROUND_MEDIA_SESSION_ID =
"com.nextcloud.client.media.BACKGROUND_MEDIA_SESSION_ID"

private const val BACKGROUND_MEDIA_SESSION_ID = "com.nextcloud.client.media.BACKGROUND_MEDIA_SESSION_ID"

const val RELEASE_MEDIA_SESSION_BROADCAST_ACTION = "com.nextcloud.client.media.RELEASE_MEDIA_SESSION"
const val STOP_MEDIA_SESSION_BROADCAST_ACTION = "com.nextcloud.client.media.STOP_MEDIA_SESSION"
const val RELEASE_MEDIA_SESSION_BROADCAST_ACTION =
"com.nextcloud.client.media.RELEASE_MEDIA_SESSION"
const val STOP_MEDIA_SESSION_BROADCAST_ACTION =
"com.nextcloud.client.media.STOP_MEDIA_SESSION"
}
}
Loading
Loading