Fix resource leaks and improve file upload collision handling

[dmiales]

Fix resource leaks and improve file upload collision handling

• Fix Cursor resource leaks in UploadsStorageManager and FileDetailSharingFragment
  by adding proper try-finally blocks to ensure cursors are always closed

• Improve file upload collision handling in UploadFileOperation

  • Add content comparison for non-encrypted files when SKIP policy is used
  • Report SYNC_CONFLICT when file with same name has different content
  • Preserve old behavior for encrypted files and edge cases

• Change log level from warning to info for informational messages
  in AutoUploadWorker and UploadErrorNotificationManager

[alperozturk96]

Hello

Thank you for the PR and for the work you’ve put into it.

Since this change touches multiple areas, including some critical components, we’d like to review and test it carefully. To help make the review process smoother and more focused, could you please consider splitting this PR into smaller, separate ones?

For example

UploadsStorageManager.java → cursor logic changes

UploadFileOperation.java → name-collision policy changes only

FileDetailSharingFragment.java → separate PR

This will help us review each change in isolation and ensure nothing is overlooked.
Thanks again for your contribution.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[alperozturk96]

Hello

Is this PR still valid?

[alperozturk96]

I’ll be closing this PR for now to keep things organized.

Please feel free to reopen it once the changes are addressed. Thank you again for your contribution.