Skip to content

fix(search-operation): add missing fields#2012

Open
alperozturk96 wants to merge 3 commits intomasterfrom
fix/add-missing-search-field
Open

fix(search-operation): add missing fields#2012
alperozturk96 wants to merge 3 commits intomasterfrom
fix/add-missing-search-field

Conversation

@alperozturk96
Copy link
Copy Markdown
Contributor

@alperozturk96 alperozturk96 commented May 8, 2026

Needed for: nextcloud/android#17004

Before After
before after

adds missing properties e.g.

<?xml version="1.0"?>
<d:multistatus
	xmlns:d="DAV:"
	xmlns:s="http://sabredav.org/ns"
	xmlns:oc="http://owncloud.org/ns"
	xmlns:nc="http://nextcloud.org/ns">
	<d:response>
		<d:href>/remote.php/dav/files/admin/2026-05-04_112731.jpg</d:href>
		<d:propstat>
			<d:prop>
				<oc:tags/>
				<d:getcontentlength>63652</d:getcontentlength>
				<d:getcontenttype>image/jpeg</d:getcontenttype>
				<d:getetag>&quot;1f050ac4b08046126c01b4287c7e9944&quot;</d:getetag>
				<d:getlastmodified>Mon, 04 May 2026 09:27:31 GMT</d:getlastmodified>
				<d:creationdate>2026-05-04T09:27:31+00:00</d:creationdate>
				<d:displayname>2026-05-04_112731.jpg</d:displayname>
				<d:resourcetype/>
				<nc:has-preview>true</nc:has-preview>
				<nc:mount-type></nc:mount-type>
				<oc:comments-unread>0</oc:comments-unread>
				<oc:favorite>1</oc:favorite>
				<oc:fileid>709</oc:fileid>
				<oc:owner-display-name>admin</oc:owner-display-name>
				<oc:owner-id>admin</oc:owner-id>
				<oc:permissions>RGDNVW</oc:permissions>
				<oc:size>63652</oc:size>
				<nc:hidden>false</nc:hidden>
				<nc:is-mount-root>false</nc:is-mount-root>
				<nc:e2ee-is-encrypted>0</nc:e2ee-is-encrypted>
				<nc:reminder-due-date></nc:reminder-due-date>
				<nc:sharees>
					<nc:sharee>
						<nc:id/>
						<nc:display-name/>
						<nc:type>3</nc:type>
					</nc:sharee>
					<nc:sharee>
						<nc:id/>
						<nc:display-name/>
						<nc:type>3</nc:type>
					</nc:sharee>
					<nc:sharee>
						<nc:id/>
						<nc:display-name/>
						<nc:type>3</nc:type>
					</nc:sharee>
					<nc:sharee>
						<nc:id/>
						<nc:display-name/>
						<nc:type>3</nc:type>
					</nc:sharee>
				</nc:sharees>
				<nc:share-attributes>[]</nc:share-attributes>
				<oc:share-types>
					<oc:share-type>3</oc:share-type>
				</oc:share-types>
				<x1:share-permissions
					xmlns:x1="http://open-collaboration-services.org/ns">19
				</x1:share-permissions>
				<nc:system-tags/>
			</d:prop>
			<d:status>HTTP/1.1 200 OK</d:status>
		</d:propstat>
		<d:propstat>
			<d:prop>
				<d:quota-available-bytes/>
				<nc:is-encrypted/>
				<nc:metadata-blurhash/>
				<nc:metadata-files-live-photo/>
				<nc:e2ee-metadata/>
				<nc:e2ee-metadata-signature/>
				<nc:note/>
				<nc:hide-download/>
				<nc:rich-workspace/>
				<nc:rich-workspace-file/>
			</d:prop>
			<d:status>HTTP/1.1 404 Not Found</d:status>
		</d:propstat>
	</d:response>
</d:multistatus>

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness2929
Dodgy code1515
Internationalization66
Malicious code vulnerability2626
Multithreaded correctness119
Performance99
Total130128

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 87.31343% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...droid/lib/resources/files/SearchRemoteOperation.kt 83.92% 5 Missing and 4 partials ⚠️
...owncloud/android/lib/common/network/WebdavEntry.kt 50.00% 4 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant