chore: update sabre dependencies to latest minor - #2526
Open
CarlSchwan wants to merge 1 commit into
Open
Conversation
8 tasks
CarlSchwan
force-pushed
the
dependabot/composer/master/sabre/dav-4.7.1
branch
from
July 22, 2026 11:39
741a591 to
d3b478e
Compare
kesselb
approved these changes
Jul 24, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the bundled Sabre libraries (dav/event/http/vobject) to newer minor/patch releases and aligns local Composer metadata accordingly, including removal of previously-applied downstream patch files now assumed to be upstreamed.
Changes:
- Bump Sabre package versions and update Composer lock/installed metadata to match.
- Pull in upstream Sabre changes across DAV/CALDAV/CARDDAV/VObject/HTTP/Event (e.g., COPY depth handling, parser hardening, timezone map updates).
- Remove local Composer patch definitions and patch artifacts for Sabre packages.
Reviewed changes
Copilot reviewed 71 out of 72 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| sabre/vobject/PATCHES.txt | Removes autogenerated patch manifest for vobject. |
| sabre/vobject/lib/Version.php | Bumps sabre/vobject version constant. |
| sabre/vobject/lib/TimezoneGuesser/FindFromTimezoneMap.php | Adjusts timezone guessing behavior and adds PHPDoc. |
| sabre/vobject/lib/timezonedata/windowszones.php | Updates Windows→IANA timezone mappings. |
| sabre/vobject/lib/timezonedata/lotuszones.php | Updates Lotus→IANA timezone mappings. |
| sabre/vobject/lib/timezonedata/exchangezones.php | Updates Exchange→IANA timezone mappings/aliases. |
| sabre/vobject/lib/Property/ICalendar/Period.php | Tweaks JSON serialization for PERIOD values (UTC suffix handling). |
| sabre/vobject/lib/Property/ICalendar/DateTime.php | Adds PHPDoc return annotations for ArrayAccess methods. |
| sabre/vobject/lib/Property.php | Adds PHPDoc return annotations for ArrayAccess methods. |
| sabre/vobject/lib/Parser/MimeDir.php | Improves token parsing and error checking in Mimedir parser. |
| sabre/vobject/lib/Node.php | Adds PHPDoc return annotations for ArrayAccess methods. |
| sabre/vobject/lib/ITip/Broker.php | Fixes/adjusts iTIP handling around EXDATE TZID, attendees, and instance mapping. |
| sabre/vobject/lib/ElementList.php | Adds PHPDoc return annotations for ArrayAccess methods. |
| sabre/vobject/lib/Document.php | Changes property factory logic (VALUE parameter handling). |
| sabre/vobject/lib/Component/VCard.php | Adds helper to fetch properties by exact TYPE set. |
| sabre/http/lib/Version.php | Bumps sabre/http version constant. |
| sabre/http/lib/Request.php | Improves absolute URL derivation when request URL is already absolute. |
| sabre/event/lib/WildcardEmitterTrait.php | Refactors listener sorting/indexing logic. |
| sabre/event/lib/Version.php | Bumps sabre/event version constant. |
| sabre/event/lib/Promise/functions.php | Minor refactor/cleanup in resolve(). |
| sabre/event/lib/Promise.php | Improves wait() error behavior when rejected without Throwable. |
| sabre/event/lib/coroutine.php | Psalm/doc tweaks and small control-flow cleanup. |
| sabre/dav/PATCHES.txt | Removes autogenerated patch manifest for dav. |
| sabre/dav/lib/DAVACL/Xml/Request/PrincipalPropertySearchReport.php | Switches element map entries to ::class references. |
| sabre/dav/lib/DAVACL/Xml/Property/CurrentUserPrivilegeSet.php | Switches element map entries to ::class references. |
| sabre/dav/lib/DAVACL/Xml/Property/Acl.php | Switches element map entries to ::class references. |
| sabre/dav/lib/DAVACL/Plugin.php | Switches resource/element map entries to ::class references. |
| sabre/dav/lib/DAV/Xml/Service.php | Switches element map entries to ::class references. |
| sabre/dav/lib/DAV/Xml/Response/MultiStatus.php | Switches element map entry to ::class reference. |
| sabre/dav/lib/DAV/Xml/Request/SyncCollectionReport.php | Switches element map entry to ::class reference. |
| sabre/dav/lib/DAV/Xml/Request/ShareResource.php | Switches element map entries to ::class references. |
| sabre/dav/lib/DAV/Xml/Request/PropPatch.php | Switches element map entries to ::class references. |
| sabre/dav/lib/DAV/Xml/Request/PropFind.php | Switches element map entry to ::class reference. |
| sabre/dav/lib/DAV/Xml/Request/MkCol.php | Switches element map entries to ::class references. |
| sabre/dav/lib/DAV/Xml/Request/Lock.php | Switches element map entry to ::class reference. |
| sabre/dav/lib/DAV/Xml/Element/Sharee.php | Switches element map entry to ::class reference. |
| sabre/dav/lib/DAV/Xml/Element/Response.php | Switches element map entry to ::class reference. |
| sabre/dav/lib/DAV/Xml/Element/Prop.php | Switches subclass check to ::class reference. |
| sabre/dav/lib/DAV/Version.php | Bumps sabre/dav version constant. |
| sabre/dav/lib/DAV/Tree.php | Adds COPY depth support to tree copy operations and hardens getChildren(). |
| sabre/dav/lib/DAV/Sync/Plugin.php | Switches element map entry to ::class reference. |
| sabre/dav/lib/DAV/Sharing/Plugin.php | Switches element map entry to ::class reference. |
| sabre/dav/lib/DAV/Server.php | Adds Depth parsing for COPY/MOVE info; adjusts Range handling; doc updates. |
| sabre/dav/lib/DAV/Locks/Plugin.php | Switches lockinfo element map entry to ::class reference; small cleanup. |
| sabre/dav/lib/DAV/ICopyTarget.php | Extends copyInto() contract to accept depth. |
| sabre/dav/lib/DAV/FSExt/File.php | Aligns delete() to not return a value. |
| sabre/dav/lib/DAV/FSExt/Directory.php | Aligns delete() to not return a value. |
| sabre/dav/lib/DAV/CorePlugin.php | Threads COPY depth through events and tree copy. |
| sabre/dav/lib/DAV/Browser/Plugin.php | Minor refactors and ::class usage for comparisons. |
| sabre/dav/lib/CardDAV/Xml/Request/AddressBookQueryReport.php | Switches element map entries to ::class references. |
| sabre/dav/lib/CardDAV/Xml/Request/AddressBookMultiGetReport.php | Switches element map entries to ::class references. |
| sabre/dav/lib/CardDAV/Plugin.php | Switches resource/element map entries to ::class references. |
| sabre/dav/lib/CardDAV/Backend/PDO.php | Uses named parameters/bindParam for card create/update and small cleanups. |
| sabre/dav/lib/CalDAV/Xml/Request/Share.php | Switches element map entries to ::class references. |
| sabre/dav/lib/CalDAV/Xml/Request/MkCalendar.php | Switches element map entries to ::class references. |
| sabre/dav/lib/CalDAV/Xml/Request/CalendarQueryReport.php | Fixes RFC section reference and switches element map entries to ::class. |
| sabre/dav/lib/CalDAV/Xml/Request/CalendarMultiGetReport.php | Switches element map entries to ::class references. |
| sabre/dav/lib/CalDAV/Subscriptions/Plugin.php | Switches resource/element map entries to ::class references. |
| sabre/dav/lib/CalDAV/SharingPlugin.php | Switches element map entries to ::class references. |
| sabre/dav/lib/CalDAV/Schedule/Plugin.php | Switches resourceTypeMapping keys to ::class references. |
| sabre/dav/lib/CalDAV/Plugin.php | Switches element/resource map entries to ::class references. |
| sabre/dav/lib/CalDAV/Notifications/Plugin.php | Switches resourceTypeMapping key to ::class reference. |
| sabre/dav/lib/CalDAV/Backend/PDO.php | Converts several statements to named params/bindParam and tweaks some assignments. |
| composer/LICENSE | Trims stray leading/trailing whitespace lines. |
| composer/installed.php | Updates installed package versions/references. |
| composer/installed.json | Updates installed package versions/references and removes patches_applied metadata. |
| composer.patches.json | Removes Sabre patch entries (dav/vobject). |
| composer.lock | Updates lockfile content-hash and Sabre package metadata. |
| composer.json | Bumps sabre/dav requirement constraint. |
| .patches/sabre-vobject-rdate.patch | Removes downstream patch file (now no longer applied). |
| .patches/sabre-vobject-iTipBroker-replies.patch | Removes downstream patch file (now no longer applied). |
| .patches/check-for-instanceof-INode-instead-of-Node-1595.patch | Removes downstream patch file (now no longer applied). |
Comments suppressed due to low confidence (1)
sabre/dav/lib/CalDAV/Backend/PDO.php:600
- Same bindParam-by-reference issue here: binding $extraData[...] directly will error because bindParam() needs a variable reference. Switch these to bindValue() (or copy to local vars) before execute().
$stmt->bindParam('etag', $extraData['etag'], \PDO::PARAM_STR);
$stmt->bindParam('size', $extraData['size'], \PDO::PARAM_INT);
$stmt->bindParam('componenttype', $extraData['componentType'], \PDO::PARAM_STR);
$stmt->bindParam('firstoccurence', $extraData['firstOccurence'], \PDO::PARAM_INT);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
dependabot/composer/master/sabre/dav-4.7.1
branch
from
August 3, 2026 09:43
d3b478e to
37a4d20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)