Skip to content

fix(uploader): rename deleteCustomerHeader to deleteCustomHeader #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skjnldsv wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

fix(uploader): rename deleteCustomerHeader to deleteCustomHeader #2106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6341ffb
fix(uploader): rename `deleteCustomerHeader` to `deleteCustomHeader`
skjnldsv Jun 14, 2026
e82016c
Merge branch 'main' into fix/rename-delete-custom-header
skjnldsv Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/uploader.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,14 @@ describe('Uploader', () => {
const uploader = new Uploader()
uploader.setCustomHeader('X-NC-Nickname', 'jane')
expect(uploader.customHeaders).toEqual({ 'X-NC-Nickname': 'jane' })
uploader.deleteCustomerHeader('X-NC-Nickname')
uploader.deleteCustomHeader('X-NC-Nickname')
expect(uploader.customHeaders).toEqual({})
})

test('unsetting non-existent header is a no-op', () => {
const uploader = new Uploader()
uploader.setCustomHeader('X-NC-Nickname', 'jane')
uploader.deleteCustomerHeader('X-Non-Existent')
uploader.deleteCustomHeader('X-Non-Existent')
expect(uploader.customHeaders).toEqual({ 'X-NC-Nickname': 'jane' })
})

Expand Down
2 changes: 1 addition & 1 deletion lib/uploader/uploader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export class Uploader {
* Unset a custom header
* @param name The header to unset
*/
deleteCustomerHeader(name: string): void {
deleteCustomHeader(name: string): void {
delete this._customHeaders[name]
}

Expand Down
Loading