π 3λ¨κ³ - μκ°μ μ²(DB μ μ©)#756
Open
gukin-han wants to merge 2 commits intonext-step:gukin-hanfrom
Open
π 3λ¨κ³ - μκ°μ μ²(DB μ μ©)#756gukin-han wants to merge 2 commits intonext-step:gukin-hanfrom
gukin-han wants to merge 2 commits intonext-step:gukin-hanfrom
Conversation
ksy90101
requested changes
Apr 21, 2025
ksy90101
left a comment
There was a problem hiding this comment.
κ°λ¨ν νΌλλ°±μ λ¨κ²Όμ΅λλ€~ νμΈ νλ² λΆνλ립λλ€!
|
|
||
| import java.time.LocalDateTime; | ||
|
|
||
| public class EnrolledStudent { |
There was a problem hiding this comment.
κ΅³μ΄ Enrolledλ₯Ό λΆμΌ μ΄μ κ° μμκΉμ?
Studentλ‘λ§μΌλ‘λ μΆ©λΆν λλ©μΈ μ€λͺ
μ΄ κ°λ₯ν΄ λ³΄μ¬μμ~
| public class EnrolledStudent { | ||
| private Long id; | ||
|
|
||
| private String userId; |
There was a problem hiding this comment.
κ°μ²΄μ§ν₯μ μΌλ‘ Userλ₯Ό κ°μ§κ³ μκ² νλ©΄ μ΄λ¨κΉμ?
| String sql = "INSERT INTO enrolled_student (session_id, user_id, enrolled_at) VALUES (?, ?, ?)"; | ||
| jdbcTemplate.update( | ||
| sql, | ||
| enrolledStudent.getSession().getId(), // session κ°μ²΄μμ id κΊΌλ |
There was a problem hiding this comment.
λλ―Έν°μ λ²μΉμ μλ°νκ² κ°μ΅λλ€.
λ°λ‘ Idλ§ λΉΌλ getterλ₯Ό λ§λμλ©΄ μ΄λ¨κΉμ?
Comment on lines
+28
to
+33
| CoverImage coverImage = new CoverImage( | ||
| rs.getInt("cover_image_size"), | ||
| ImageType.valueOf(rs.getString("cover_image_type")), | ||
| rs.getInt("cover_image_width"), | ||
| rs.getInt("cover_image_height") | ||
| ); |
There was a problem hiding this comment.
CoverImageκ° μ¬μ¬μ©λ μΌμ΄ μμκΉμ?
μ κ·ν κ΄μ μμ νλ² κ³ λ―Όν΄λ³΄μ
¨μΌλ©΄ μ’κ² μ΅λλ€.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
μλ νμΈμ 리뷰μ΄λ!
3λ¨κ³ λ―Έμ μ DBμ λλ©μΈμ λΆλ¦¬ κ°κ°μ λ껴보λκ² μλμΈκ² κ°μ΅λλ€.
λ무 μκ° λΊκΈ°λκ² κ°μμ μλΉμ€ λ μ΄μ΄μμ νμλ‘ νλ DAOμ λ©μλλ§ μ΅μνμΌλ‘ ꡬννμ΄μ. μλλ μ κ° μκ°νλ μ΄ λ―Έμ μμ μ»μ΄κ°μΌν μκ°λ€μ μ 리ν΄λ³΄μμ΅λλ€.