Merged
Conversation
networmix
added
enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new "TrafficMatrixPlacementAnalysis" workflow step that analyzes traffic demand placement success rates under network failures. The implementation includes demand placement scheduling utilities, separate containers for traffic matrices and failure policies, and adds enhanced flow detail collection capabilities.
Key Changes
- Added TrafficMatrixPlacementAnalysis workflow step with Monte Carlo demand placement analysis
- Refactored TrafficMatrixSet and FailurePolicySet into separate modules from results artifacts
- Enhanced demand placement analysis with flow details and per-demand statistics
- Added placement envelope artifacts and analysis utilities
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ngraph/workflow/traffic_matrix_placement_analysis.py | New workflow step for traffic matrix demand placement analysis |
| ngraph/demand/matrix.py | Moved TrafficMatrixSet from results artifacts to dedicated module |
| ngraph/failure/policy_set.py | Moved FailurePolicySet from results artifacts to dedicated module |
| ngraph/demand/manager/expand.py | Extracted demand expansion logic from TrafficManager |
| ngraph/demand/manager/schedule.py | Extracted round-robin scheduling logic from TrafficManager |
| ngraph/results/artifacts.py | Added PlacementEnvelope artifact, removed moved classes |
| ngraph/monte_carlo/functions.py | Enhanced demand_placement_analysis with flow details support |
| tests/workflow/test_traffic_matrix_placement_analysis.py | Tests for new workflow step |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.