Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a bugfix and bumps the version to v0.8.1. The primary fix removes obsolete name attributes from failure policy definitions throughout the codebase, addressing schema validation issues and API consistency.
Key changes include:
- Version bump from v0.8.0 to v0.8.1 in pyproject.toml
- Removal of
namefield from failure policyattrssections across all configuration files and tests - Addition of comprehensive integration tests for workflow analysis, failure manager, and CLI functionality
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Version bump to v0.8.1 |
| Multiple YAML scenario files | Removed obsolete name attributes from failure policies |
| Multiple test files | Updated test expectations to remove name validation and added new test coverage |
| ngraph/scenario.py | Updated documentation to reflect name field removal |
| ngraph/failure_policy.py | Updated example in docstring to remove name field |
| ngraph/cli.py | Added missing parameter to NetworkExplorer.explore_network call |
| docs/ files | Updated documentation examples to remove name fields |
Comments suppressed due to low confidence (1)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Owner
Author
|
closing #86 |
github-project-automation
bot
moved this to Done
in NetGraph for Analysis of Backbone Networks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.