Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the NetGraph project for v0.8.0 release with TopoGen compatibility. The changes focus on removing verbose marketing language from docstrings and comments while updating Python version requirements.
- Removes redundant qualifier words like "comprehensive" and "fully" from documentation
- Updates minimum Python version requirement from 3.9 to 3.11
- Updates generated documentation timestamps
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ngraph/workflow/network_stats.py | Removes "comprehensive" from module docstring |
| ngraph/traffic_demand.py | Removes "fully" from flow_policy attribute description |
| ngraph/monte_carlo/results.py | Removes "comprehensive" from export_summary method docstrings |
| ngraph/lib/flow_policy.py | Changes "re-optimize" to "update" in parameter descriptions and comments |
| ngraph/blueprints.py | Removes "fully" from return type description |
| docs/reference/api-full.md | Updates generated documentation with cleaner language and new timestamp |
| docs/getting-started/installation.md | Updates minimum Python version from 3.9 to 3.11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release will be compatible with TopoGen