Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances developer experience, updates dataclass usage, and refines DSL expansion logic.
- Refactors
@dataclassdeclarations (removesslots=True) and cleans up import ordering. - Adjusts DSL expansion functions: uses
Nonedefault for inherited risk groups and employszip(..., strict=False)for adjacency variables. - Adds/updates developer tooling: setup/check scripts, CLI for API docs, Makefile targets, and CI workflows.
Reviewed Changes
Copilot reviewed 96 out of 96 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ngraph/components.py | Removed slots=True, reordered imports, updated from_dict. |
| ngraph/blueprints.py | Changed default arg to None, added strict=False to zip(). |
| dev/generate_api_docs.py | Introduced argparse, refined exception, added file output. |
| dev/setup-dev.sh & dev/run-checks.sh | New scripts for env setup and QA checks. |
| Makefile & dev/dev.md | New/updated dev commands and documentation. |
| .github/workflows/python-test.yml | Expanded Python matrix, added lint and type-check steps. |
Comments suppressed due to low confidence (4)
ngraph/blueprints.py:165
- Add or update a test case for
_expand_groupwheninherited_risk_groupsis not provided to verify the new default behavior initializes an empty set.
inherited_risk_groups: Set[str] | None = None,
ngraph/components.py:10
- [nitpick] Previously declared
@dataclass(slots=True)to save memory and improve attribute access; if slotted instances are desired, consider re-addingslots=True.
@dataclass
ngraph/blueprints.py:421
- The
strictparameter forzip()requires Python 3.10+. Ensure your project’s minimum Python version supports this change or adjust accordingly.
combo_dict = dict(zip(var_names, combo_tuple, strict=False))
dev/generate_api_docs.py:245
- The indentation of the diagnostic
printstatements after writing the file appears inconsistent. Ensure allprintcalls are correctly nested underif output_to_file:so thatoutput_pathis always defined when used.
if output_to_file:
There was a problem hiding this comment.
✅ BugBot reviewed your changes and found no bugs!
BugBot free trial expires on June 10, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing #71