Update XR sh eigrp neigh timestamp regex#2273
Update XR sh eigrp neigh timestamp regex#2273GutturalOnion wants to merge 11 commits intonetworktocode:masterfrom
Conversation
TextFSM template for the IOS-XR command "show eigrp neighbors".
…eigrp-neighbors Create cisco_xr_show_eigrp_neighbors.textfsm
Update the index file to match the CLI input for the Cisco IOS XR command "show eigrp neighbors"
Test files for the IOS XR command "show eigrp neighbors"
Removing the .gitkeep file since there's test data in that directory now.
Updated regex pattern for time-stamp matching in EIGRP neighbors template.
GutturalOnion
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa,
matt852 and
mjbear
as code owners
|
For single digit dates, timestamps have an extra space following the day of the week. I've updated the regex to account for this. |
Hi, please add test data to accompany the template change. (This requirement was set [long before my involvement] to gain a level of confidence that bugs and breakage wasn't inadvertently being introduced.) Thank you! PS: (This comment meant to be helpful, not judgemental) It might be helpful to develop in a feature branch to compartmentalize changes. Hope it helps. |
mjbear
added
the
status: action required
mjbear
changed the title
All right, I will do so. Thank you for your input. |
2 participants
(cisco_xr show eigrp neighbors)
Fixed Regex for timestamp matching to account for single-digit dates.