Improvements to Google Parser #375
Open
+830
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriusV4
requested review from
glennmatthews,
jvanderaa,
pke11y and
scetron
as code owners
Contributor
glennmatthews
left a comment
glennmatthews
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks solid at a quick readthrough. Would you mind adding a changelog fragment?
Author
|
Thanks, added changelog fragment |
jvanderaa
approved these changes
Feb 11, 2026
Contributor
jvanderaa
left a comment
jvanderaa
left a comment
There was a problem hiding this comment.
Looking good with just one spelling in a comment suggestion.
| match = re.search(r" - Reference (.*)$", summary) | ||
| data["summary"] = summary | ||
| data["maintenance_id"] = match[1] | ||
| # Google sometimes send notifications without End Time specificed |
Contributor
There was a problem hiding this comment.
Suggested change
| # Google sometimes send notifications without End Time specificed | |
| # Google sometimes send notifications without End Time specified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Google parser statically sets status to CONFIRMED for all maintenances. But Google sends emails with multiple statuses (Scheduled, Completed, Canceled). To cover this:
statusparsing to subject parser (HTML status parsing is cumbersome because 'Scheduled' status maintenances have no status in the main div, only 'Completed' and 'Canceled' do (and the status is in a separate element, so current HTML parsing logic was failing on those)summaryandmaintenance_idparsing to subject parser for simplicityAlso Google sometimes send maintenances without any End Date specified at all, so to cover this:
Also added multiple tests to cover both parsers and e2e functionality as well.