-
-
Notifications
You must be signed in to change notification settings - Fork 110
Connection: added inTransaction() #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pavolbiely
wants to merge
1
commit into
nette:master
Choose a base branch
from
pavolbiely:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b70c0e to
dfb79e3
Compare
cba566a to
302586e
Compare
Author
|
Is there something wrong with the implementation? I could help but got no response. |
Contributor
|
@dg What do you think? |
Member
|
Please can you add simple test? |
4c0e8d0 to
e17242a
Compare
f9fc19d to
dd75e74
Compare
cce6a9c to
7e705c5
Compare
9acf825 to
a268c60
Compare
a56e7fe to
d9b5f29
Compare
cdb8832 to
a1798c0
Compare
1769a67 to
b02f117
Compare
2d78899 to
2f04c73
Compare
e8459f8 to
23617a8
Compare
2da238e to
038bab3
Compare
d3018bd to
9dc391a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
inTransaction()method might be a very useful shortcut.Calling is unnecessary long right now.
Why not just use it like this?
Other shortcuts like
beginTransaction(),commit()androllback()are already implemented inConnectionclass.