Skip to content

fix upgrade-all version change and path reporting - #130

Merged
CybotTM merged 3 commits into
mainfrom
agent/upgrade-all-version-reporting
Jul 27, 2026
Merged

fix upgrade-all version change and path reporting#130
CybotTM merged 3 commits into
mainfrom
agent/upgrade-all-version-reporting

Conversation

@CybotTM

@CybotTM CybotTM commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary

  • capture each package manager, runtime, and uv tool version before running its updater
  • report either old → new or version unchanged after a successful update command
  • resolve executable locations from the real binary name (python3, node, go, ruby, rustc) instead of display labels such as Python and Node.js
  • add regression coverage for changed versions, unchanged versions, real executable paths, and the runtime stage integration

Root cause

log_success_with_info used its display label as the argument to command -v, so labels such as Python, Node.js, and Rust always resolved to unknown. It also evaluated versions only after the updater returned, so the output could not say whether anything changed.

User impact

Successful make upgrade-all rows now make the outcome explicit, for example:

✓ Python (3.14.5 → 3.14.6 at /home/user/.local/bin/python3)
✓ Node.js (26.5.0 unchanged at /home/user/.nvm/versions/node/v26.5.0/bin/node)

Validation

  • red/green regression cycle confirmed against the previous implementation
  • uv run pytest -q — 747 passed, 1 skipped
  • all repository pre-commit hooks pass for the changed files
  • Bash syntax and ShellCheck pass

Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

CybotTM added 2 commits July 27, 2026 15:45
Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
@sonarqubecloud

Copy link
Copy Markdown

@CybotTM CybotTM left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent focused review completed against main.

Initial review findings covered system package-manager reporting, uv package-to-binary mapping, authoritative uv package versions, unavailable-version handling, and pip interpreter/path consistency. All findings were addressed and re-reviewed. Final result: no Critical or Important blockers; ready to merge.

Final local validation: 7 focused regression tests pass, full suite 751 passed / 1 skipped, pre-commit hooks, Bash syntax, ShellCheck, and diff checks pass.

@CybotTM
CybotTM marked this pull request as ready for review July 27, 2026 13:52
Copilot AI review requested due to automatic review settings July 27, 2026 13:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@CybotTM
CybotTM merged commit da519cf into main Jul 27, 2026
24 of 25 checks passed
@CybotTM
CybotTM deleted the agent/upgrade-all-version-reporting branch July 27, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants