fix upgrade-all version change and path reporting - #130
Merged
Conversation
Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
|
CybotTM
commented
Jul 27, 2026
CybotTM
left a comment
Member
Author
There was a problem hiding this comment.
Independent focused review completed against main.
Initial review findings covered system package-manager reporting, uv package-to-binary mapping, authoritative uv package versions, unavailable-version handling, and pip interpreter/path consistency. All findings were addressed and re-reviewed. Final result: no Critical or Important blockers; ready to merge.
Final local validation: 7 focused regression tests pass, full suite 751 passed / 1 skipped, pre-commit hooks, Bash syntax, ShellCheck, and diff checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
old → neworversion unchangedafter a successful update commandpython3,node,go,ruby,rustc) instead of display labels such asPythonandNode.jsRoot cause
log_success_with_infoused its display label as the argument tocommand -v, so labels such asPython,Node.js, andRustalways resolved tounknown. It also evaluated versions only after the updater returned, so the output could not say whether anything changed.User impact
Successful
make upgrade-allrows now make the outcome explicit, for example:Validation
uv run pytest -q— 747 passed, 1 skipped