[NAE-2439] Implement new filter data types#332
Conversation
- create new filter field as text field for filter query
- introduce new field types
|
Warning Review limit reached
More reviews will be available in 59 minutes and 59 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
rabbit please review this PR |
| registry.register("file-list-default", (injector: Injector) => new ComponentPortal<any>(FileListDefaultFieldComponent, null, injector)); | ||
| registry.register("filter-default", (injector: Injector) => new ComponentPortal<any>(FilterDefaultFieldComponent, null, injector)); | ||
| registry.register("filter-filter-tab-view", (injector: Injector) => new ComponentPortal<any>(FilterDefaultFieldComponent, null, injector)); | ||
| registry.register("filter-string_query", (injector: Injector) => new ComponentPortal<any>(FilterStringQueryFieldComponent, null, injector)); |
There was a problem hiding this comment.
Is this intended that default component for filter field is still filterDefaultComponent when we remove all metadata stuff?
There was a problem hiding this comment.
I think, that for now yes. For the tasks' formulars, backend always sends string_query component, so FilterStringQueryFieldComponent will be used . Anywhere else is used filter component as before



Description
Introduced new filter field component
string_queryImplements NAE-2439
Dependencies
No new dependencies were introduced
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
Manually and by test
Test Configuration
Checklist: