Add missing otel signal viewer plugin for the otel Agent#532
Open
ralphm wants to merge 1 commit into
Open
Conversation
Member
Author
|
@M4itee We may want to add some other plugins as well, like We currently have |
Contributor
|
we can, the goal was for this endpoint to ONLY host logs (no overhead) |
Member
Author
|
Per out-of-band discussion, this change should be sufficient for the time being. Please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the default configuration explicitly disables "new" plugins, all plugins that are not explicitly enabled will be disabled. Since the set of enabled plugins for use within k8s has been created a while ago, new plugins such as the
otel-signal-viewerplugin are not mentioned, even though we do expect them to be there.