fix(smoke): stabilise mcp-permissions-tool-grid screenshot capture#1474
Merged
Aaronontheweb merged 5 commits intoJun 24, 2026
Merged
Conversation
Two changes to address flaky mcp-permissions-tool-grid captures (see netclaw-dev#1471): 1. Tape: increase pre-Enter settle guard from 1s → 2s and add a 500ms post-Wait+Screen settle before Screenshot. The Wait+Screen anchors fire on first match but VHS can race with a Spectre Console full-refresh repaint triggered by a daemon event (tool re-index, reconnect) arriving immediately after navigation. The 500ms absorbs that repaint window. 2. Harness: raise SHOT_BLANK_RETRIES default from 3 → 5. The retry logic correctly detects the transient capture via AE comparison; 3 attempts weren't enough headroom under CI load for this frame. Fixes netclaw-dev#1471
Aaronontheweb
added
the
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Entersettle guard in themcp-permissionsscreenshot tape from 1s → 2s, reducing the window where an in-flight daemon tool-reindex can causeEnterto land mid-transitionWait+Screensettle before theScreenshotcall, absorbing the Spectre Console full-refresh repaint that can race with VHS's frame capture after the anchors fireSHOT_BLANK_RETRIESdefault from 3 → 5 as defense-in-depth so the existing AE-based retry logic has more headroom under CI loadRoot cause (from #1471)
Wait+Screen /record-tasks/andWait+Screen /Server default:/both fire correctly (VHS exits 0), but VHS'sScreenshotraces with a Spectre Console full-refresh triggered by a daemon event (tool re-index / reconnect notification) arriving immediately after navigation. The repaint clears the screen and redraws — VHS captures the intermediate state, which is the server-selection screen rather than the tool grid. The AE-based retry detects this correctly but 3 retries were exhausted before a clean capture landed.Test plan
./scripts/smoke/run-smoke.sh lightpasses locally (mcp-permissions tape)mcp-permissions-tool-gridframe reportsPASSat AE=0Closes #1471