feat(dry-run): add PyATS dry-run support#554
Open
oboehmer wants to merge 4 commits intorelease/pyats-integration-v1.1-betafrom
Open
feat(dry-run): add PyATS dry-run support#554oboehmer wants to merge 4 commits intorelease/pyats-integration-v1.1-betafrom
oboehmer wants to merge 4 commits intorelease/pyats-integration-v1.1-betafrom
Conversation
Add --dry-run support for PyATS tests. Previously, --dry-run only worked for Robot Framework tests while PyATS tests would execute anyway. PyATS dry-run behavior: - Discovers and categorizes tests (API vs D2D) normally - Prints which tests would be executed without actually running them - Returns exit code 0 (no tests executed = no failures) Changes: - Add dry_run parameter to PyATSOrchestrator - Add _print_dry_run_summary() method to display discovered tests - Update CombinedOrchestrator to pass dry_run to PyATSOrchestrator - Update CLI --dry-run help text to describe PyATS behavior - Add unit tests for PyATS dry-run functionality - Add E2E tests with mixed Robot + PyATS scenario
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
--dry-runsupport for PyATS tests. Previously,--dry-runonly worked for Robot Framework tests while PyATS tests would execute anyway.PyATS dry-run behavior:
Example output:
Closes
--dry-runoption is ignored for pyats tests #460Related Issue(s)
Type of Change
Test Framework Affected
Network as Code (NaC) Architecture Affected
Platform Tested
Key Changes
dry_runparameter toPyATSOrchestrator.__init__()_print_dry_run_summary()method to display discovered testsCombinedOrchestratorto passdry_runtoPyATSOrchestrator--dry-runhelp text to describe PyATS behaviorTesting Done
pytest/pre-commit run -a)Test Commands Used
Checklist
pre-commit run -apasses)Screenshots (if applicable)
N/A
Additional Notes
The dry-run implementation intercepts after test discovery and categorization but before job file generation and execution. This ensures that all validation (file discovery, categorization logic) is exercised while preventing actual test execution.