Skip to content

fix(publish): verify release by id after upload, not by tag #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Finesssee merged 1 commit into from
Aug 15, 2026
Merged

fix(publish): verify release by id after upload, not by tag #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/publish-github-release.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ function Get-Release {
}
}

function Get-ReleaseById {
param([Parameter(Mandatory)][string]$Id)

return Invoke-GhJson @('api', "repos/$Repository/releases/$Id")
}

function New-DraftRelease {
return Invoke-GhJson @(
'api', '--method', 'POST', "repos/$Repository/releases",
Expand Down Expand Up @@ -264,7 +270,7 @@ foreach ($path in $assetPaths) {
}
throw
}
$release = Get-Release
$release = Get-ReleaseById ([string]$release.id)
if (-not $release -or -not [bool]$release.draft) {
throw "Release $Tag disappeared or is no longer draft after uploading $name."
}
Expand Down
Loading