Skip to content

Wrap gh API calls in ErrorActionPreference Continue #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Finesssee merged 1 commit into from
Aug 15, 2026
+27 −8
Merged

Wrap gh API calls in ErrorActionPreference Continue #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions scripts/publish-github-release.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,14 @@ function Invoke-GhJson {
$stdoutPath = [IO.Path]::GetTempFileName()
$stderrPath = [IO.Path]::GetTempFileName()
try {
& $gh.Source @Arguments 1>$stdoutPath 2>$stderrPath
$exitCode = $LASTEXITCODE
$previousErrorActionPreference = $ErrorActionPreference
try {
$ErrorActionPreference = 'Continue'
& $gh.Source @Arguments 1>$stdoutPath 2>$stderrPath
$exitCode = $LASTEXITCODE
} finally {
$ErrorActionPreference = $previousErrorActionPreference
}
if ($exitCode -ne 0) {
$errorText = Get-Content -Raw -LiteralPath $stderrPath -ErrorAction SilentlyContinue
throw "gh $($Arguments -join ' ') failed with exit code $($exitCode): $errorText"
Expand All @@ -51,10 +57,16 @@ function Invoke-GhJson {
function Invoke-GhUpload {
param([Parameter(Mandatory)][string]$Path)

$gh = Get-Command gh -ErrorAction Stop
& $gh.Source release upload $Tag $Path '--repo' $Repository
if ($LASTEXITCODE -ne 0) {
throw "gh release upload failed for $(Split-Path $Path -Leaf) with exit code $LASTEXITCODE"
$previousErrorActionPreference = $ErrorActionPreference
try {
$ErrorActionPreference = 'Continue'
& $gh.Source release upload $Tag $Path '--repo' $Repository 2>&1 | ForEach-Object { Write-Host $_ }
$uploadExitCode = $LASTEXITCODE
} finally {
$ErrorActionPreference = $previousErrorActionPreference
}
if ($uploadExitCode -ne 0) {
throw "gh release upload failed for $(Split-Path $Path -Leaf) with exit code $uploadExitCode"
}
}

Expand All @@ -63,8 +75,15 @@ function Get-Release {
$stdoutPath = [IO.Path]::GetTempFileName()
$stderrPath = [IO.Path]::GetTempFileName()
try {
& $gh.Source api "repos/$Repository/releases/tags/$Tag" 1>$stdoutPath 2>$stderrPath
if ($LASTEXITCODE -eq 0) {
$previousErrorActionPreference = $ErrorActionPreference
try {
$ErrorActionPreference = 'Continue'
& $gh.Source api "repos/$Repository/releases/tags/$Tag" 1>$stdoutPath 2>$stderrPath
$ghExitCode = $LASTEXITCODE
} finally {
$ErrorActionPreference = $previousErrorActionPreference
}
if ($ghExitCode -eq 0) {
return Get-Content -Raw -LiteralPath $stdoutPath | ConvertFrom-Json
}
$errorText = Get-Content -Raw -LiteralPath $stderrPath -ErrorAction SilentlyContinue
Expand Down
Loading