Skip to content

fix: correct grammar and wording in code comments #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
walker27 merged 1 commit into from
Mar 23, 2026
Merged

fix: correct grammar and wording in code comments #3452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/neuron-wallet/src/controllers/multisig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export default class MultisigController {
const network = NetworksService.getInstance().getCurrent()
if (params.startBlockNumber && network.type === NetworkType.Light) {
if (config?.startBlockNumber !== undefined && config.startBlockNumber > params.startBlockNumber) {
// if set small than last, reset by set_script
// if set smaller than last, reset by set_script
this.resetMultisigSync(config, params.startBlockNumber)
}
// if it's light client, restart queue task
Expand Down
2 changes: 1 addition & 1 deletion packages/neuron-wallet/src/models/chain/input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default class Input {
public data?: string | null
public status?: OutputStatus

// don't using = directly, using setXxx instead
// don't use = directly, use setXxx instead
// check hex string
constructor(
previousOutput: OutPoint | null,
Expand Down
2 changes: 1 addition & 1 deletion packages/neuron-wallet/src/services/addresses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export default class AddressService {
receivingAddressCount: number = DefaultAddressNumber.Receiving,
changeAddressCount: number = DefaultAddressNumber.Change
) => {
// can be only receiving OR only change
// can be either only receiving OR only change
if (receivingAddressCount < 1 && changeAddressCount < 1) {
throw new Error('Address number error.')
} else if (receivingAddressCount > MAX_ADDRESS_COUNT || changeAddressCount > MAX_ADDRESS_COUNT) {
Expand Down
2 changes: 1 addition & 1 deletion packages/neuron-wallet/src/services/cells.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ export default class CellsService {
const currentNetwork = NetworksService.getInstance().getCurrent()

// https://github.com/nervosnetwork/neuron/blob/dbc5a5b46dc108f660c443d43aba54ea47e233ac/packages/neuron-wallet/src/services/tx/transaction-persistor.ts#L70
// datum in outputs has been sliced when sync
// data in outputs has been sliced when sync
// to make the Spore NFT data available,
// we need to fetch it from RPC instead of database
const rpc = generateRPC(currentNetwork.remote, currentNetwork.type)
Expand Down
Loading